Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and copy build.log #2327

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Save and copy build.log #2327

merged 2 commits into from
Dec 17, 2024

Conversation

ruhan1
Copy link
Contributor

@ruhan1 ruhan1 commented Dec 17, 2024

This is for JBS-70. According to @rnc 's comment that directly changing buildah task would "...affect multiple teams. we should...keeping the changes isolated to only our code base", I move the change here.

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

Hi @ruhan1. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rnc
Copy link
Collaborator

rnc commented Dec 17, 2024

/ok-to-test

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

@ruhan1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/jvm-build-service-in-repo-e2e 95c1f1c link true /test jvm-build-service-in-repo-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
@rnc
Copy link
Collaborator

rnc commented Dec 17, 2024

/lgtm

@rnc
Copy link
Collaborator

rnc commented Dec 17, 2024

Note : the e2e tests will fail due to the addition of domain proxy but JBS is being removed from Konflux so those tests will go away anyway.

@rnc rnc merged commit 43cb638 into redhat-appstudio:main Dec 17, 2024
7 of 12 checks passed
@ruhan1 ruhan1 deleted the main-log branch December 18, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants