Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver module and CLI to control it #2286

Merged
merged 22 commits into from
Dec 5, 2024
Merged

Conversation

rnc
Copy link
Collaborator

@rnc rnc commented Nov 26, 2024

Note this also includes a CLI to invoke the pipeline outside of the build driver (which I found very useful for testing). Even if the majority of this code is then migrated to PNC I think it would still be helpful for an initial commit.

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 38.37838% with 114 lines in your changes missing coverage. Please review.

Project coverage is 43.74%. Comparing base (34a2cc4) to head (0696a3c).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...main/java/com/redhat/hacbs/cli/driver/Fabric8.java 0.00% 53 Missing ⚠️
...va/com/redhat/hacbs/cli/driver/CreatePipeline.java 0.00% 22 Missing ⚠️
.../src/main/java/com/redhat/hacbs/driver/Driver.java 70.76% 18 Missing and 1 partial ⚠️
...va/com/redhat/hacbs/cli/driver/CancelPipeline.java 0.00% 8 Missing ⚠️
.../build/preprocessor/maven/MavenPrepareCommand.java 40.00% 1 Missing and 2 partials ⚠️
...java/com/redhat/hacbs/driver/endpoints/Public.java 75.00% 3 Missing ⚠️
...ava/com/redhat/hacbs/driver/dto/CancelRequest.java 0.00% 2 Missing ⚠️
...rc/main/java/com/redhat/hacbs/cli/driver/Base.java 0.00% 1 Missing ⚠️
...ava/com/redhat/hacbs/cli/driver/DriverCommand.java 0.00% 1 Missing ⚠️
...dhat/hacbs/driver/clients/IndyTokenRequestDTO.java 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2286      +/-   ##
============================================
- Coverage     43.84%   43.74%   -0.11%     
+ Complexity      803      802       -1     
============================================
  Files           275      288      +13     
  Lines         13263    13442     +179     
  Branches       1346     1349       +3     
============================================
+ Hits           5815     5880      +65     
- Misses         6850     6961     +111     
- Partials        598      601       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnc rnc force-pushed the NCL8774 branch 2 times, most recently from 70a54bf to 19c9648 Compare November 27, 2024 15:00
@rnc rnc marked this pull request as ready for review November 28, 2024 12:13
@openshift-ci openshift-ci bot requested a review from vibe13 November 28, 2024 12:13
@rnc rnc requested a review from matejonnet December 2, 2024 21:26
@rnc
Copy link
Collaborator Author

rnc commented Dec 4, 2024

/retest

@rnc rnc merged commit abd490d into redhat-appstudio:main Dec 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant