Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Tekton Logs Collector using Kustomize generator #5178

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Install Tekton Logs Collector using Kustomize generator #5178

merged 1 commit into from
Dec 19, 2024

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Dec 18, 2024

ArgoCD CR's Application/ApplicationSet CR isn't available in every cluster. So we switched to using kustomize generator for vector installation.

khrm
khrm commented Dec 18, 2024
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @enarha

@khrm khrm force-pushed the vectorKus branch 11 times, most recently from 60a93f0 to c7c5ce6 Compare December 18, 2024 18:44
@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • quay: Build System

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

1 similar comment
@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • quay: Build System

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • quay: Build System

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

1 similar comment
@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • quay: Build System

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • quay: Build System

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

1 similar comment
@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • quay: Build System

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

@khrm
Copy link
Contributor Author

khrm commented Dec 19, 2024

/test appstudio-e2e-tests

1 similar comment
@khrm
Copy link
Contributor Author

khrm commented Dec 19, 2024

/test appstudio-e2e-tests

@khrm khrm requested review from enarha and removed request for ramessesii2 December 19, 2024 03:55
@khrm khrm force-pushed the vectorKus branch 2 times, most recently from 8d11e3f to df96d72 Compare December 19, 2024 11:31
@khrm
Install Tekton Logs Collector using Kustomize generator
6be76a9 
ArgoCD CR's Application/ApplicationSet CR isn't available in every cluster.
So we switched to using kustomize generator for vector installation.
khrm
khrm commented Dec 19, 2024
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enarha I have removed the prod changes.

@enarha
Copy link
Contributor

enarha commented Dec 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 19, 2024
@enarha
Copy link
Contributor

enarha commented Dec 19, 2024

/hold

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khrm
Copy link
Contributor Author

khrm commented Dec 19, 2024

Vector got deployed to Dev env.
image

/hold cancel

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2024

@khrm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-upgrade-tests 6be76a9 link false /test appstudio-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2b140d7 into redhat-appstudio:main Dec 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enarha enarha enarha left review comments

@xinredhat xinredhat Awaiting requested review from xinredhat

Assignees

@enarha enarha

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khrm @redhat-appstudio-qe-bot @enarha