Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project-controller update #5153

Merged
merged 2 commits into from
Dec 18, 2024
Merged

project-controller update #5153

merged 2 commits into from
Dec 18, 2024

Conversation

rh-tap-build-team[bot]
Copy link
Contributor

@rh-tap-build-team rh-tap-build-team bot commented Dec 16, 2024 •
edited
Loading

@openshift-ci openshift-ci bot requested review from gbenhaim and ifireball December 16, 2024 11:10
@yftacherzog yftacherzog self-requested a review December 17, 2024 12:03
yftacherzog
yftacherzog approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rh-tap-build-team[bot], yftacherzog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yftacherzog
Copy link
Member

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 17, 2024 •
edited
Loading

@rh-tap-build-team[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-upgrade-tests d4a16ea link false /test appstudio-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yftacherzog
Copy link
Member

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 9210147 into main Dec 18, 2024
5 of 6 checks passed
@yftacherzog yftacherzog deleted the project-controller branch December 18, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yftacherzog yftacherzog yftacherzog approved these changes

@gbenhaim gbenhaim Awaiting requested review from gbenhaim

@ifireball ifireball Awaiting requested review from ifireball

Assignees

@yftacherzog yftacherzog

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yftacherzog