Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(KFLUXVNGD-128): Delete old crossplane namespace claims #5094

Merged
merged 1 commit into from
Dec 18, 2024
Merged

chore(KFLUXVNGD-128): Delete old crossplane namespace claims #5094

merged 1 commit into from
Dec 18, 2024

Conversation

hmariset
Copy link
Contributor

Delete crossplane namespace claims periodically to prevent the compute provided.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-128

@openshift-ci openshift-ci bot requested review from lcarva and skabashnyuk December 10, 2024 02:12
@hmariset hmariset requested review from amisstea and removed request for skabashnyuk and lcarva December 10, 2024 02:12
amisstea
amisstea requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@amisstea amisstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need another component for this? I was thinking this CronJob and its config could reside in crossplane-control-plane since it's a tightly coupled dependency.

components/namespace-claim-cleaner/base/rbac.yaml Outdated Show resolved Hide resolved
components/namespace-claim-cleaner/base/rbac.yaml Outdated Show resolved Hide resolved
components/namespace-claim-cleaner/base/namespace-claim-configmap.yaml Outdated Show resolved Hide resolved
@hmariset hmariset force-pushed the KFLUXVNGD-128 branch 3 times, most recently from 62aa37f to b4ab40e Compare December 13, 2024 22:25
amisstea
amisstea reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@amisstea amisstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmariset please include some evidence showing how this was tested in a dev cluster with it successfully cleaning up stale namespace claims while ignoring others.

components/crossplane-control-plane/base/cronjob.yaml Outdated Show resolved Hide resolved
components/crossplane-control-plane/base/namespace-claim-configmap.yaml Outdated Show resolved Hide resolved
components/crossplane-control-plane/base/namespace-claim-configmap.yaml Outdated Show resolved Hide resolved
components/crossplane-control-plane/base/namespace-claim-configmap.yaml Outdated Show resolved Hide resolved
components/crossplane-control-plane/base/namespace-claim-configmap.yaml Outdated Show resolved Hide resolved
@hmariset hmariset force-pushed the KFLUXVNGD-128 branch 4 times, most recently from c084199 to 2df288b Compare December 18, 2024 20:21
@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • quay: Build System

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

1 similar comment
@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • quay: Build System

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

@hmariset
Copy link
Contributor Author

image
Successfully deleted "my-namespace" in "test-pvc".

@hmariset
Copy link
Contributor Author

image
When there are no namespaces.eaas.konflux-ci.dev resources.

@hmariset
Copy link
Contributor Author

To create sample namespaces.eaas.konflux-ci.dev object you can use the example from crossplane-control-plane repo.
kubectl apply -f examples/xnamespace/claim.yaml

@hmariset
chore(KFLUXVNGD-128): Delete old crossplane namespace claims
7a9f95c 
Delete crossplane namespace claims periodically to prevent the
compute provided.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-128
Signed-off-by: Homaja Marisetty <[email protected]>
amisstea
amisstea approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@amisstea amisstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisstea, hmariset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 633fa83 into redhat-appstudio:main Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisstea amisstea amisstea approved these changes

Assignees

@amisstea amisstea

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmariset @redhat-appstudio-qe-bot @amisstea