Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce resource requests/limits for gitops #3433

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: reduce resource requests/limits for gitops #3433

merged 1 commit into from
Mar 14, 2024

Conversation

psturc
Copy link
Member

@psturc psturc commented Mar 14, 2024 •
edited
Loading

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@psturc
Copy link
Member Author

psturc commented Mar 14, 2024

/test appstudio-hac-e2e-tests

@psturc
Copy link
Member Author

psturc commented Mar 14, 2024

/test all

psturc
psturc commented Mar 14, 2024
View reviewed changes
components/gitops/development/core_service_resources_patch.yaml
resources:
requests:
cpu: 100m
memory: 100Mi
Copy link
Member Author

@psturc psturc Mar 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous requests:

              cpu: '1'
              memory: 2400Mi

actual usage when e2e-tests are running:
Screenshot 2024-03-14 at 7 23 07

psturc
psturc commented Mar 14, 2024
View reviewed changes
components/gitops/development/gitops-service-argocd.yaml
resources:
requests:
cpu: 100m
memory: 100Mi
Copy link
Member Author

@psturc psturc Mar 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous requests:

              cpu: 500m
              memory: 512Mi

actual usage when e2e-tests are running:
Screenshot 2024-03-14 at 7 24 32

psturc
psturc commented Mar 14, 2024
View reviewed changes
components/gitops/development/service_agent_resources_patch.yaml
resources:
requests:
cpu: 50m
memory: 100Mi
Copy link
Member Author

@psturc psturc Mar 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous requests:

              cpu: 200m
              memory: 300Mi

actual usage when e2e-tests are running:
Screenshot 2024-03-14 at 7 23 44

@psturc psturc marked this pull request as ready for review March 14, 2024 08:42
@openshift-ci openshift-ci bot requested review from arewm and ksprinkl March 14, 2024 08:42
@psturc
Copy link
Member Author

psturc commented Mar 14, 2024 •
edited by openshift-ci bot
Loading

known issue KFLUXBUGS-580
/retest-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgwest, psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasemAlem
Copy link
Member

/lgtm

@openshift-merge-bot openshift-merge-bot bot merged commit 185923a into redhat-appstudio:main Mar 14, 2024
8 checks passed
@psturc psturc deleted the KFLUXBUGS-1154 branch March 14, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgwest jgwest jgwest approved these changes

@arewm arewm Awaiting requested review from arewm

@ksprinkl ksprinkl Awaiting requested review from ksprinkl

Assignees

@kasemAlem kasemAlem

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psturc @kasemAlem @jgwest @stuartwdouglas