-
Notifications
You must be signed in to change notification settings - Fork 45
Updates roles and permissions topic #137
base: main
Are you sure you want to change the base?
Conversation
🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app |
🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app |
abce6cb
to
6c73537
Compare
🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app |
Hi @gtrivedi88 I accidentally committed changes to the red hat style folder (which is a Vale thing). What is the best thing to do? Should I try to remove this commit or just include it? |
🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app |
Hi @chloeredhat , I think it's best to remove the |
|
||
|Create | ||
|Create a workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permissions to create and delete a workspace for admin is a bit misleading. Users (even admins) can't create additional workspaces or delete existing ones. I would remove Workspace sections from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, do you mean keep the "update" and "view" and delete the "create" and "delete"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does a workspace "update" mean? How someone updates a workspace? I would just drop the entire Workspace section. Everyone can view workspaces they have access to (no matter what role). No one can create new or delete existing ones. And it's unclear what "update" means. :)
docs/modules/ROOT/pages/getting-started/roles_persmissions.adoc
Outdated
Show resolved
Hide resolved
67159d4
to
e047905
Compare
🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app |
e047905
to
39acd5e
Compare
🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app |
1 similar comment
🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app |
4aad3b7
to
6d274d4
Compare
🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app |
The redhat-appstudio docs are deprecated. Would you be able to recreate a similar PR on konflux-ci/docs if needed? |
Awaiting SME review please don't review/merge yet