Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Updates roles and permissions topic #137

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Updates roles and permissions topic #137

wants to merge 7 commits into from

Conversation

chloeredhat
Copy link
Contributor

Awaiting SME review please don't review/merge yet

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app

@github-actions
Copy link

🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app

@chloeredhat
Copy link
Contributor Author

Hi @gtrivedi88 I accidentally committed changes to the red hat style folder (which is a Vale thing). What is the best thing to do? Should I try to remove this commit or just include it?

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app

@gtrivedi88
Copy link
Collaborator

Hi @gtrivedi88 I accidentally committed changes to the red hat style folder (which is a Vale thing). What is the best thing to do? Should I try to remove this commit or just include it?

Hi @chloeredhat , I think it's best to remove the styles/RedHat directory. We do not have this directory in our repository. You may have this directory in your current branch. You can simply delete it and push the changes. Let me know if you have any questions.

@chloeredhat chloeredhat added size: M and removed size: XXL Very large labels Sep 5, 2023

|Create
|Create a workspace

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permissions to create and delete a workspace for admin is a bit misleading. Users (even admins) can't create additional workspaces or delete existing ones. I would remove Workspace sections from here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, do you mean keep the "update" and "view" and delete the "create" and "delete"?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does a workspace "update" mean? How someone updates a workspace? I would just drop the entire Workspace section. Everyone can view workspaces they have access to (no matter what role). No one can create new or delete existing ones. And it's unclear what "update" means. :)

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🚀 Preview is available at https://pr-137--boisterous-meerkat-894982.netlify.app

@arewm
Copy link
Contributor

arewm commented Jul 17, 2024

The redhat-appstudio docs are deprecated. Would you be able to recreate a similar PR on konflux-ci/docs if needed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants