Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Gaurav Trivedi <[email protected]>
  • Loading branch information
ernesgonzalez33 and gtrivedi88 authored May 2, 2024
1 parent ca3ad89 commit 31e102a
Showing 1 changed file with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -125,17 +125,17 @@ By default, all pipelines push the images to the `quay.io/redhat-user-workloads`

.Procedure

. You will need a secret to push the images to your Quay repo.
.. Follow Quay's link:https://docs.quay.io/glossary/robot-accounts.html[docs] to create a robot account for your repo.
. You need a secret to push images to your Quay repo.
.. Follow Quay's link:https://docs.quay.io/glossary/robot-accounts.html[documentation] to create a robot account for your repository.
.. Give push access to your repository to the robot account.
.. Retrieve the `.dockercfg` from the "Docker Configuration" menu on your robot account credentials page.
.. Follow the steps to link:proc_creating-secrets-for-your-builds.adoc[create a secret for your build] and do it as an "Image Pull Secret".
.. Follow the steps to link:proc_creating-secrets-for-your-builds.adoc[create a secret for your build] as an "Image Pull Secret".

[NOTE]
====
You need to delete the `"auths": {` and one `}` at the end of the docker config file for the secret to work. Until this https://issues.redhat.com/browse/KFLUXBUGS-1160[bug] is resolved.
You need to delete the `"auths": {` and one `}` at the end of the docker config file for the secret to work, pending the resolution of https://issues.redhat.com/browse/KFLUXBUGS-1160[KFLUXBUGS-1160] bug.
For example, this is how you will get the file from Quay:
For example, this is how you get the file from Quay:
[source, json]
----
{
Expand All @@ -162,8 +162,8 @@ And this is how you should upload it to Konflux:

[start=2]
. Go to the GitHub repo of your component.
. In each .yaml file in the .tekton directory, under params, locate the param named output-image:
.. Change it to the new repository. For example: `quay.io/my-new-quay-repo/my-app:on-pr-{\{revision}}` for the `pull-request` pipeline, and `quay.io/my-new-quay-repo/my-app:{\{revision}}` for the `push` pipeline. This is a best practice to know which images come from a Pull Request and which don't.
. In each .yaml file within the .tekton directory, under `params`, locate the parameter named `output-image`:
.. Change it to relflect your new repository. For example: `quay.io/my-new-quay-repo/my-app:on-pr-{\{revision}}` for the `pull-request` pipeline, and `quay.io/my-new-quay-repo/my-app:{\{revision}}` for the `push` pipeline. This distinction helps identify which images originate from a Pull Request and which do not.

== Verification

Expand Down

0 comments on commit 31e102a

Please sign in to comment.