Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update on-pull and on-push pipelines #490

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

14rcole
Copy link
Collaborator

@14rcole 14rcole commented Nov 20, 2024

Need to fix these so that changes can be promoted in infra-deployments

What does this PR do?:

Which issue(s)/story(ies) does this PR fixes:

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

@14rcole 14rcole force-pushed the update-build-plrs branch 8 times, most recently from 3f14b38 to e06fad0 Compare November 20, 2024 19:02
Need to fix these so that changes can be promoted in infra-deployments

Signed-off-by: Ryan Cole <[email protected]>
Copy link
Member

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dheerajodha
Copy link
Member

/test application-service-e2e

@dirgim
Copy link
Member

dirgim commented Nov 21, 2024

/test application-service-e2e

Copy link
Member

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 14rcole, dheerajodha, dirgim, hongweiliu17, Josh-Everett, kasemAlem
Once this PR has been reviewed and has the lgtm label, please assign yangcao77 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dheerajodha
Copy link
Member

/test application-service-e2e

Sorry for the confusion. The e2e tests job won't run on this repo, since it's always failing to get a cluster. I think somebody disabled the cluster access to this repo to save costs.

So, we can ignore the job failures and merge the PR whenever we see fit.

Copy link

openshift-ci bot commented Nov 21, 2024

@14rcole: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/application-service-e2e 6ab4658 link true /test application-service-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dirgim dirgim merged commit 38f1c98 into redhat-appstudio:main Nov 21, 2024
11 of 12 checks passed
@dirgim
Copy link
Member

dirgim commented Nov 21, 2024

/test application-service-e2e

Sorry for the confusion. The e2e tests job won't run on this repo, since it's always failing to get a cluster. I think somebody disabled the cluster access to this repo to save costs.

So, we can ignore the job failures and merge the PR whenever we see fit.

Ack, merging this in light of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants