-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update on-pull and on-push pipelines #490
Conversation
3f14b38
to
e06fad0
Compare
Need to fix these so that changes can be promoted in infra-deployments Signed-off-by: Ryan Cole <[email protected]>
e06fad0
to
6ab4658
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test application-service-e2e |
/test application-service-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 14rcole, dheerajodha, dirgim, hongweiliu17, Josh-Everett, kasemAlem The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry for the confusion. The e2e tests job won't run on this repo, since it's always failing to get a cluster. I think somebody disabled the cluster access to this repo to save costs. So, we can ignore the job failures and merge the PR whenever we see fit. |
@14rcole: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Ack, merging this in light of that. |
Need to fix these so that changes can be promoted in infra-deployments
What does this PR do?:
Which issue(s)/story(ies) does this PR fixes:
PR acceptance criteria:
Unit/Functional tests
Documentation
Client Impact
How to test changes / Special notes to the reviewer: