Fix Encoding #181
Merged
Fix Encoding #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberbuff
changed the title
Revert "fixing NoExecutionLog" This reverts commit 84a357a. fixing NoExecutionLog
This reverts commit 7250851.
cyberbuff
commented
Dec 28, 2023
| @@ -20,3 +20,4 @@ jobs: | |||
| } | |||
| IEX (IWR 'https://raw.githubusercontent.com/${{ github.event.pull_request.head.repo.full_name }}/${{ github.event.pull_request.head.ref }}/install-atomicsfolder.ps1' -UseBasicParsing); | |||
| Install-AtomicsFolder -Force | |||
| Invoke-AtomicTest All -ShowDetailsBrief | |||
There was a problem hiding this comment.
Running Invoke-AtomicTest to check whether the commands actually work after installing AtomicRedTeam
clr2of8
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like PSScriptAnalyzer changed the encoding of all files from UTF8 to UTF8 with BOM(Byte Order Mark). The encoding shouldn't affect importing modules through Powershell commandline. But whenever a function is downloaded through IWR, it parses only UTF8 characters. Hence reverting everything back to UTF8
From the Docs:
When you used Fix, Invoke-ScriptAnalyzer applies the fixes before running the analysis. Make sure that you have a backup of your files when using this parameter. It tries to preserve the file encoding but there are still some cases where the encoding can change.