Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to pause runner between atomics & invoke-commandfix #161

Merged
merged 4 commits into from
Oct 14, 2023

Conversation

clr2of8
Copy link
Collaborator

@clr2of8 clr2of8 commented Oct 10, 2023

This PR introduces a "-PauseBetweenAtomics" option to be used with "Invoke-AtomicRunner -ListOfAtomics" where you specify the number of seconds to pause between executions. If you specify zero, you will be prompted to press any key to run the next atomic.

This PR has an internal improvement to pass arguments as an array of strings instead of a single string which avoids problems of quoting double quotes inside of double quotes.

Fixes an issue introduced with the "-anyOS" PR where atomics that don't apply to the given OS are being invoked. For example, invoking T1016 on linux would attempt to run all of the atomics even though only one applies to linux.

Also, not redirecting stdin during atomic execution because the redirected input wasn't being used anywhere and was breaking some atomics (such as those that use ADFind)

Testing on Windows and Linux

@clr2of8 clr2of8 marked this pull request as ready for review October 10, 2023 22:29
@cyberbuff cyberbuff merged commit 8e9d23b into redcanaryco:master Oct 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants