Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2258560: [release-4.15] Fetches cluster fsid through secret and not mc #191

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #190

/assign vbnrh

vbnrh added 2 commits February 1, 2024 03:45
This commit fixes the issue with hub recovery where the new hub cluster does not have managedcluster CRs updated due to clusterclaims
on the managed clusters being in an non updated state.

We are changing the method from looking into the MC CRs to fetching it from the rook secret synced on hub.

Signed-off-by: vbadrina <[email protected]>
@vbnrh
Copy link
Member

vbnrh commented Feb 1, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Feb 1, 2024
Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 1, 2024
@vbnrh
Copy link
Member

vbnrh commented Feb 1, 2024

/retitle Bug 2258560: [release-4.15] Fetches cluster fsid through secret and not mc

@openshift-ci openshift-ci bot changed the title [release-4.15] Fetches cluster fsid through secret and not mc Bug 2258560: [release-4.15] Fetches cluster fsid through secret and not mc Feb 1, 2024
Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2258560, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.0) matches configured target release for branch (ODF 4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2258560: [release-4.15] Fetches cluster fsid through secret and not mc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2258560, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.0) matches configured target release for branch (ODF 4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2258560: [release-4.15] Fetches cluster fsid through secret and not mc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit df6315f into red-hat-storage:release-4.15 Feb 1, 2024
11 checks passed
Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2258560 has been moved to the MODIFIED state.

In response to this:

Bug 2258560: [release-4.15] Fetches cluster fsid through secret and not mc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants