Sort package.json alphabetically #1791
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
SanjalKatiyar
requested review from
alfonsomthd,
GowthamShanmugam and
bipuladh
and removed request for
alfonsomthd and
GowthamShanmugam
| @@ -2,3 +2,5 @@ | |||
| . "$(dirname "$0")/_/husky.sh" | |||
|
|
|||
| npx lint-staged | |||
| yarn sort:packagejson | |||
| git add . | |||
There was a problem hiding this comment.
This is dangeorus as I can have some files that I don't want it to be added to the commit that'll be added silently.
| git add . | |
| git add package.json |
There was a problem hiding this comment.
@SanjalKatiyar Instead of adding any file, we can make pre-commit fail so the contributor can run yarn sort:packagejson manually and commit again. Thoughts?
There was a problem hiding this comment.
let's move forward with #1792 instead of any manual efforts... I will close this PR.
Add https://www.npmjs.com/package/sort-package-json to
husky.