Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-945: [release-4.16] Fix webhook warning in bucket and obc creation #1780

Open
wants to merge 1 commit into
base: release-4.16
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/odf/components/create-bs/create-bs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ const CreateBackingStoreForm: React.FC<CreateBackingStoreFormProps> = (
},
spec: {
type: NOOBAA_TYPE_MAP[provider],
ssl: false,
},
};
if (provider === BC_PROVIDERS.PVC) {
Expand Down
4 changes: 1 addition & 3 deletions packages/odf/components/mcg/CreateObjectBucketClaim.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,7 @@ export const CreateOBCForm: React.FC<CreateOBCFormProps> = (props) => {
metadata: {
namespace,
},
spec: {
ssl: false,
},
spec: {},
};
if (state.scName) {
obj.spec.storageClassName = state.scName;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ const externalProviders = getExternalProviders(StoreType.NS);
type Payload = K8sResourceCommon & {
spec: {
type: string;
ssl: boolean;
[key: string]: any;
};
};
Expand Down Expand Up @@ -208,7 +207,6 @@ const NamespaceStoreForm: React.FC<NamespaceStoreFormProps> = (props) => {
},
spec: {
type: NOOBAA_TYPE_MAP[provider],
ssl: false,
},
};
if (externalProviders.includes(provider)) {
Expand Down
1 change: 0 additions & 1 deletion packages/odf/types/mcg.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export type BackingStoreKind = K8sResourceCommon & {
export type MCGPayload = K8sResourceCommon & {
spec: {
type: string;
ssl: boolean;
[key: string]: any;
};
};
Expand Down
1 change: 0 additions & 1 deletion packages/odf/utils/mcg.ts
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ export const createNewObjectBucketClaim = (
namespace,
},
spec: {
ssl: false,
storageClassName,
generateBucketName: name,
additionalConfig: {
Expand Down
Loading