Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning message is triggered for healthy replication #1755

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix warning message is triggered for healthy replication #1755

merged 1 commit into from
Dec 6, 2024

Conversation

TimothyAsirJeyasing
Copy link
Contributor

@TimothyAsirJeyasing TimothyAsirJeyasing commented Dec 5, 2024 •
edited
Loading

alfonsomthd
alfonsomthd reviewed Dec 5, 2024
View reviewed changes
...es/mco/components/modals/app-failover-relocate/parser/discovered-application-parser.spec.tsx
@@ -464,4 +480,76 @@ describe('Discovered application failover/relocate modal test', () => {
expect(screen.getByRole('button', { name: /Cancel/i })).toBeEnabled();
expect(screen.getByRole('button', { name: /Initiate/i })).toBeDisabled();
});

test('Volume synchronization delay during relocate', async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for adding tests.

GowthamShanmugam
GowthamShanmugam reviewed Dec 5, 2024
View reviewed changes
packages/mco/components/modals/app-failover-relocate/parser/discovered-application-parser.tsx
@@ -159,6 +159,7 @@ export const DiscoveredApplicationParser: React.FC<
isDRActionReady: checkDRActionReadiness(drPlacementControl, action),
snapshotTakenTime: drPlacementControl?.status?.lastGroupSyncTime,
replicationType: findDRType(drClusters),
schedulingInterval: drPolicy?.spec?.schedulingInterval,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the problem with using Partial<> type on PlacementControlProps. We need to remove partial soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

GowthamShanmugam
GowthamShanmugam reviewed Dec 5, 2024
View reviewed changes
...es/mco/components/modals/app-failover-relocate/parser/discovered-application-parser.spec.tsx Outdated Show resolved Hide resolved
...es/mco/components/modals/app-failover-relocate/parser/discovered-application-parser.spec.tsx Outdated Show resolved Hide resolved
packages/mco/__mocks__/drplacementcontrol.tsx Outdated Show resolved Hide resolved
...ages/mco/components/modals/app-failover-relocate/parser/argo-application-set-parser.spec.tsx Outdated Show resolved Hide resolved
...ages/mco/components/modals/app-failover-relocate/parser/argo-application-set-parser.spec.tsx Outdated Show resolved Hide resolved
...ages/mco/components/modals/app-failover-relocate/parser/argo-application-set-parser.spec.tsx Outdated Show resolved Hide resolved
...ages/mco/components/modals/app-failover-relocate/parser/argo-application-set-parser.spec.tsx Outdated Show resolved Hide resolved
...ages/mco/components/modals/app-failover-relocate/parser/argo-application-set-parser.spec.tsx Outdated Show resolved Hide resolved
...ages/mco/components/modals/app-failover-relocate/parser/argo-application-set-parser.spec.tsx Outdated Show resolved Hide resolved
...ages/mco/components/modals/app-failover-relocate/parser/argo-application-set-parser.spec.tsx Outdated Show resolved Hide resolved
@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the fix-warning-issue-for-healthy-replication branch from c0e2944 to 3af536b Compare December 5, 2024 10:13
@TimothyAsirJeyasing
Copy link
Contributor Author

image
image
image

image
image
image

@TimothyAsirJeyasing
Copy link
Contributor Author

Screenshot from 2024-12-05 17-44-55
Screenshot from 2024-12-05 17-44-44
Screenshot from 2024-12-05 17-44-19
Screenshot from 2024-12-05 17-44-10

GowthamShanmugam
GowthamShanmugam reviewed Dec 6, 2024
View reviewed changes
...es/mco/components/modals/app-failover-relocate/parser/discovered-application-parser.spec.tsx
});

test('No volume synchronization delay during relocate', async () => {
type = 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is tested in my local, it is raising cluster down alert
expect(
screen.getByRole('heading', {
name: /Danger alert: 1 or more managed clusters are offline./i,
})
).toBeInTheDocument()

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the fix-warning-issue-for-healthy-replication branch from 3af536b to 1b3087f Compare December 6, 2024 08:48
@openshift-ci openshift-ci bot added the lgtm label Dec 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GowthamShanmugam, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fdf816d into red-hat-storage:master Dec 6, 2024
5 checks passed
@GowthamShanmugam
Copy link
Contributor

/cherry-pick release-4.18

@GowthamShanmugam
Copy link
Contributor

/cherry-pick release-4.18-compatibility

@openshift-cherrypick-robot
Copy link

@GowthamShanmugam: new pull request created: #1758

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 6, 2024
Merged
@openshift-cherrypick-robot
Copy link

@GowthamShanmugam: new pull request created: #1759

In response to this:

/cherry-pick release-4.18-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd left review comments

@GowthamShanmugam GowthamShanmugam GowthamShanmugam approved these changes

Assignees

@GowthamShanmugam GowthamShanmugam

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TimothyAsirJeyasing @GowthamShanmugam @openshift-cherrypick-robot @alfonsomthd