Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves upload component to mobX #1732

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Nov 27, 2024

https://issues.redhat.com//browse/DFBUGS-989

Changes introduced in this PR:

  1. Introduces mobx and mobx-react-lite as core dependencies.
  2. Intorduces eslint-plugin-mobx as a dev dependency.
  3. Updates @typescript-eslint/parser

Issue

  1. The upload experience did not scale well with large number of documents.
  2. The upload experience couldn't handle Cancel all synchronously.

Changes

This PR introduces mobx as state management library for the Upload feature.
The cancellation feature has been enhanced by batching mechanisms.

@bipuladh bipuladh force-pushed the mobx-switch branch 2 times, most recently from fb4e862 to 749f591 Compare December 3, 2024 08:32
@bipuladh bipuladh changed the title [WIP] Moves upload component to mobX Moves upload component to mobX Dec 3, 2024
@bipuladh bipuladh force-pushed the mobx-switch branch 2 times, most recently from 09c6327 to 4a61a83 Compare December 5, 2024 08:15
@bipuladh bipuladh changed the title Moves upload component to mobX DFBUGS-989: Moves upload component to mobX Dec 5, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Dec 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2024

@bipuladh: This pull request references [Jira Issue DFBUGS-989](https://issues.redhat.com//browse/DFBUGS-989), which is valid. The bug has been moved to the POST state.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Changes introduced in this PR:

  1. Introduces mobx and mobx-react-lite as core dependencies.
  2. Intorduces eslint-plugin-mobx as a dev dependency.
  3. Updates @typescript-eslint/parser

Issue

  1. The upload experience did not scale well with large number of documents.
  2. The upload experience couldn't handle Cancel all synchronously.

Changes

This PR introduces mobx as state management library for the Upload feature.
The cancellation feature has been enhanced by batching mechanisms.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alfonsomthd
Copy link
Collaborator

LGTM. @SanjalKatiyar to tag.

Signed-off-by: Bipul Adhikari <[email protected]>
@SanjalKatiyar
Copy link
Collaborator

/retitle Moves upload component to mobX

@openshift-ci openshift-ci bot changed the title DFBUGS-989: Moves upload component to mobX Moves upload component to mobX Dec 9, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid jira ticket of any type label Dec 9, 2024
@SanjalKatiyar
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Dec 9, 2024
@openshift-ci-robot
Copy link

@bipuladh: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Changes introduced in this PR:

  1. Introduces mobx and mobx-react-lite as core dependencies.
  2. Intorduces eslint-plugin-mobx as a dev dependency.
  3. Updates @typescript-eslint/parser

Issue

  1. The upload experience did not scale well with large number of documents.
  2. The upload experience couldn't handle Cancel all synchronously.

Changes

This PR introduces mobx as state management library for the Upload feature.
The cancellation feature has been enhanced by batching mechanisms.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SanjalKatiyar
Copy link
Collaborator

/cherry-pick release-4.18

@openshift-cherrypick-robot

@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SanjalKatiyar
Copy link
Collaborator

/cherry-pick release-4.18-compatibility

@openshift-cherrypick-robot

@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.18-compatibility in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit deb2cff into red-hat-storage:master Dec 9, 2024
9 checks passed
@openshift-cherrypick-robot

@SanjalKatiyar: new pull request created: #1760

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@SanjalKatiyar: new pull request created: #1761

In response to this:

/cherry-pick release-4.18-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants