-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves upload component to mobX #1732
Moves upload component to mobX #1732
Conversation
packages/odf/components/s3-browser/objects-list/ObjectListWithSidebar.tsx
Outdated
Show resolved
Hide resolved
packages/odf/components/s3-browser/upload-objects/upload-status/UploadStatusBasedAlert.tsx
Outdated
Show resolved
Hide resolved
packages/odf/components/s3-browser/objects-list/ObjectListWithSidebar.tsx
Outdated
Show resolved
Hide resolved
packages/odf/components/s3-browser/upload-objects/upload-component/FileUploadComponent.tsx
Outdated
Show resolved
Hide resolved
packages/odf/components/s3-browser/objects-list/ObjectListWithSidebar.tsx
Outdated
Show resolved
Hide resolved
packages/odf/components/s3-browser/upload-objects/UploadSidebar.tsx
Outdated
Show resolved
Hide resolved
fb4e862
to
749f591
Compare
packages/odf/components/s3-browser/objects-list/ObjectListWithSidebar.tsx
Outdated
Show resolved
Hide resolved
packages/odf/components/s3-browser/upload-objects/UploadSidebar.tsx
Outdated
Show resolved
Hide resolved
packages/odf/components/s3-browser/upload-objects/upload-component/FileUploadComponent.tsx
Outdated
Show resolved
Hide resolved
packages/odf/components/s3-browser/upload-objects/upload-component/uploads.ts
Outdated
Show resolved
Hide resolved
packages/odf/components/s3-browser/upload-objects/upload-status/UploadStatusItem.tsx
Outdated
Show resolved
Hide resolved
packages/odf/components/s3-browser/upload-objects/upload-status/UploadStatusItem.tsx
Outdated
Show resolved
Hide resolved
09c6327
to
4a61a83
Compare
@bipuladh: This pull request references [Jira Issue DFBUGS-989](https://issues.redhat.com//browse/DFBUGS-989), which is valid. The bug has been moved to the POST state. 2 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
LGTM. @SanjalKatiyar to tag. |
packages/odf/components/s3-browser/upload-objects/upload-component/uploads.ts
Outdated
Show resolved
Hide resolved
packages/odf/components/s3-browser/upload-objects/upload-component/uploads.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Bipul Adhikari <[email protected]>
/retitle Moves upload component to mobX |
/lgtm |
@bipuladh: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.18 |
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-4.18-compatibility |
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
deb2cff
into
red-hat-storage:master
@SanjalKatiyar: new pull request created: #1760 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@SanjalKatiyar: new pull request created: #1761 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com//browse/DFBUGS-989
Changes introduced in this PR:
mobx
andmobx-react-lite
as core dependencies.eslint-plugin-mobx
as a dev dependency.Issue
Cancel all
synchronously.Changes
This PR introduces mobx as state management library for the Upload feature.
The cancellation feature has been enhanced by batching mechanisms.