Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug DFBUGS-933: [release-4.14-compatibility]tough-cookie: prototype pollution in cookie memstore #1729

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Bug DFBUGS-933: [release-4.14-compatibility]tough-cookie: prototype pollution in cookie memstore #1729

merged 1 commit into from
Dec 19, 2024

Conversation

GowthamShanmugam
Copy link
Contributor

@GowthamShanmugam GowthamShanmugam commented Nov 26, 2024 •
edited
Loading

@GowthamShanmugam
Copy link
Contributor Author

GowthamShanmugam commented Dec 12, 2024 •
edited by openshift-ci bot
Loading

/retitle Bug DFBUGS-933: [release-4.14-compatibility]tough-cookie: prototype pollution in cookie memstore

@openshift-ci openshift-ci bot changed the title Bug 2304972: [release-4.14-compatibility] CVE-2023-26136 odf-multicluster-console-container: tough-cookie: prototype pollution in cookie memstore Bug DFBUGS-933: [release-4.14-compatibility]tough-cookie: prototype pollution in cookie memstore Dec 12, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 12, 2024 •
edited by openshift-ci bot
Loading

@GowthamShanmugam: This pull request references [Jira Issue DFBUGS-933](https://issues.redhat.com//browse/DFBUGS-933), which is invalid:

  • expected the bug to target the "odf-4.14.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Issue: https://issues.redhat.com/browse/DFBUGS-933

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bipuladh
Copy link
Contributor

/approve
/lgtm

@GowthamShanmugam
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Dec 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 16, 2024 •
edited by openshift-ci bot
Loading

@GowthamShanmugam: This pull request references [Jira Issue DFBUGS-933](https://issues.redhat.com//browse/DFBUGS-933), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.14.13) matches configured target version for branch (odf-4.14.13)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @PrasadDesala

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting label Dec 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024 •
edited
Loading

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@GowthamShanmugam: This pull request references [Jira Issue DFBUGS-933](https://issues.redhat.com//browse/DFBUGS-933), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.14.13) matches configured target version for branch (odf-4.14.13)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @PrasadDesala

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GowthamShanmugam
Copy link
Contributor Author

/hold

@GowthamShanmugam
Bug 2304972: [release-4.14-compatibility] CVE-2023-26136 odf-multiclu…
3eac127 
…ster-console-container: tough-cookie: prototype pollution in cookie memstore

Signed-off-by: Gowtham Shanmugasundaram <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Dec 19, 2024
@SanjalKatiyar
Copy link
Collaborator

/hold cancel

@SanjalKatiyar
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, GowthamShanmugam, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4889f83 into red-hat-storage:release-4.14-compatibility Dec 19, 2024
6 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024 •
edited by openshift-ci bot
Loading

@GowthamShanmugam: [Jira Issue DFBUGS-933](https://issues.redhat.com//browse/DFBUGS-933): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-933](https://issues.redhat.com//browse/DFBUGS-933) has been moved to the MODIFIED state.

In response to this:

Issue: https://issues.redhat.com/browse/DFBUGS-933

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SanjalKatiyar SanjalKatiyar

@bipuladh bipuladh

Labels
approved jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GowthamShanmugam @openshift-ci-robot @bipuladh @SanjalKatiyar