Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-923: [release-4.14-compatibility] Fix security issue: Backtracking regular expressions #1711

Conversation

alfonsomthd
Copy link
Collaborator

IMPORTANT: merge after #1628

Fixes: https://issues.redhat.com/browse/DFBUGS-923

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024

@alfonsomthd: This pull request references [Jira Issue DFBUGS-923](https://issues.redhat.com//browse/DFBUGS-923), which is valid. The bug has been moved to the POST state.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

IMPORTANT: merge after #1628

Fixes: https://issues.redhat.com/browse/DFBUGS-923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alfonsomthd alfonsomthd changed the base branch from master to release-4.14-compatibility November 25, 2024 11:26
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024

@alfonsomthd: This pull request references [Jira Issue DFBUGS-923](https://issues.redhat.com//browse/DFBUGS-923), which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

IMPORTANT: merge after #1628

Fixes: https://issues.redhat.com/browse/DFBUGS-923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alfonsomthd
Copy link
Collaborator Author

/test

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

@alfonsomthd: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test images
/test odf-console-e2e-aws

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the approved label Nov 25, 2024
@alfonsomthd alfonsomthd changed the base branch from release-4.14-compatibility to release-4.14 November 25, 2024 14:54
@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024

@alfonsomthd: This pull request references [Jira Issue DFBUGS-923](https://issues.redhat.com//browse/DFBUGS-923), which is invalid:

  • expected the bug to target the "odf-4.14.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

IMPORTANT: merge after #1628

Fixes: https://issues.redhat.com/browse/DFBUGS-923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting label Nov 25, 2024
@alfonsomthd alfonsomthd changed the base branch from release-4.14 to release-4.14-compatibility November 25, 2024 14:55
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024

@alfonsomthd: This pull request references [Jira Issue DFBUGS-923](https://issues.redhat.com//browse/DFBUGS-923), which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

IMPORTANT: merge after #1628

Fixes: https://issues.redhat.com/browse/DFBUGS-923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting label Nov 25, 2024
@alfonsomthd
Copy link
Collaborator Author

/test sanity-checks

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

@alfonsomthd: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test images
/test odf-console-e2e-aws

Use /test all to run all jobs.

In response to this:

/test sanity-checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alfonsomthd alfonsomthd changed the base branch from release-4.14-compatibility to release-4.14 November 25, 2024 15:03
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting and removed jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024

@alfonsomthd: This pull request references [Jira Issue DFBUGS-923](https://issues.redhat.com//browse/DFBUGS-923), which is invalid:

  • expected the bug to target the "odf-4.14.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

IMPORTANT: merge after #1628

Fixes: https://issues.redhat.com/browse/DFBUGS-923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alfonsomthd
Copy link
Collaborator Author

/test sanity-checks

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

@alfonsomthd: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test images
/test odf-console-e2e-aws

Use /test all to run all jobs.

In response to this:

/test sanity-checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024

@alfonsomthd: This pull request references [Jira Issue DFBUGS-923](https://issues.redhat.com//browse/DFBUGS-923), which is invalid:

  • expected the bug to target the "odf-4.14.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

IMPORTANT: merge after #1628

Fixes: https://issues.redhat.com/browse/DFBUGS-923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting label Nov 25, 2024
@alfonsomthd alfonsomthd changed the base branch from release-4.14 to release-4.14-compatibility November 25, 2024 16:38
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024

@alfonsomthd: This pull request references [Jira Issue DFBUGS-923](https://issues.redhat.com//browse/DFBUGS-923), which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

IMPORTANT: merge after #1628

Fixes: https://issues.redhat.com/browse/DFBUGS-923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alfonsomthd alfonsomthd changed the title DFBUGS-923: [release-4.14-compatibility] Fix security issue: Backtracking regular expressionsx DFBUGS-923: [release-4.14-compatibility] Fix security issue: Backtracking regular expressions Nov 25, 2024
@alfonsomthd alfonsomthd changed the base branch from release-4.14-compatibility to release-4.14 November 25, 2024 16:43
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting and removed jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024

@alfonsomthd: This pull request references [Jira Issue DFBUGS-923](https://issues.redhat.com//browse/DFBUGS-923), which is invalid:

  • expected the bug to target the "odf-4.14.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

IMPORTANT: merge after #1628

Fixes: https://issues.redhat.com/browse/DFBUGS-923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alfonsomthd alfonsomthd changed the base branch from release-4.14 to release-4.14-compatibility November 25, 2024 16:45
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024

@alfonsomthd: This pull request references [Jira Issue DFBUGS-923](https://issues.redhat.com//browse/DFBUGS-923), which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

IMPORTANT: merge after #1628

Fixes: https://issues.redhat.com/browse/DFBUGS-923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alfonsomthd alfonsomthd force-pushed the fix-backtracking-414-compat branch from 281f365 to e81a726 Compare December 13, 2024 13:18
@bipuladh
Copy link
Contributor

/approve
/lgtm

@bipuladh
Copy link
Contributor

/test odf-console-e2e-aws

@openshift-ci openshift-ci bot added the lgtm label Dec 16, 2024
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alfonsomthd, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GowthamShanmugam
Copy link
Contributor

/test odf-console-e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit 799a507 into red-hat-storage:release-4.14-compatibility Dec 16, 2024
6 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 16, 2024

@alfonsomthd: [Jira Issue DFBUGS-923](https://issues.redhat.com//browse/DFBUGS-923) is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

IMPORTANT: merge after #1628

Fixes: https://issues.redhat.com/browse/DFBUGS-923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants