Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-922: [release-4.15] Fix security issue: Backtracking regular expressions #1708

Merged
merged 1 commit into from
Dec 16, 2024
Merged

DFBUGS-922: [release-4.15] Fix security issue: Backtracking regular expressions #1708

merged 1 commit into from
Dec 16, 2024

Conversation

alfonsomthd
Copy link
Collaborator

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024 •
edited by openshift-ci bot
Loading

@alfonsomthd: This pull request references [Jira Issue DFBUGS-922](https://issues.redhat.com//browse/DFBUGS-922), which is valid. The bug has been moved to the POST state.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/DFBUGS-922

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alfonsomthd alfonsomthd changed the base branch from master to release-4.15 November 25, 2024 09:10
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting and removed jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024 •
edited by openshift-ci bot
Loading

@alfonsomthd: This pull request references [Jira Issue DFBUGS-922](https://issues.redhat.com//browse/DFBUGS-922), which is invalid:

  • expected the bug to target the "odf-4.15.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Fixes: https://issues.redhat.com/browse/DFBUGS-922

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alfonsomthd
Copy link
Collaborator Author

/retest

1 similar comment
@alfonsomthd
Copy link
Collaborator Author

/retest

@alfonsomthd
Copy link
Collaborator Author

/test all

@SanjalKatiyar
Copy link
Collaborator

/test odf-console-e2e-aws

@alfonsomthd
Copy link
Collaborator Author

/test all

@alfonsomthd alfonsomthd changed the base branch from release-4.15 to release-4.15-compatibility November 25, 2024 14:56
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024 •
edited by openshift-ci bot
Loading

@alfonsomthd: This pull request references [Jira Issue DFBUGS-922](https://issues.redhat.com//browse/DFBUGS-922), which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Fixes: https://issues.redhat.com/browse/DFBUGS-922

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alfonsomthd alfonsomthd changed the base branch from release-4.15-compatibility to release-4.15 November 25, 2024 14:57
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting and removed jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024 •
edited by openshift-ci bot
Loading

@alfonsomthd: This pull request references [Jira Issue DFBUGS-922](https://issues.redhat.com//browse/DFBUGS-922), which is invalid:

  • expected the bug to target the "odf-4.15.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Fixes: https://issues.redhat.com/browse/DFBUGS-922

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added lgtm and removed approved labels Dec 12, 2024
@GowthamShanmugam
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Dec 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 12, 2024 •
edited by openshift-ci bot
Loading

@GowthamShanmugam: This pull request references [Jira Issue DFBUGS-922](https://issues.redhat.com//browse/DFBUGS-922), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.15.z) matches configured target version for branch (odf-4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting label Dec 12, 2024
@alfonsomthd
Copy link
Collaborator Author

@bipuladh @SanjalKatiyar ping

@vbnrh
Copy link
Member

vbnrh commented Dec 13, 2024

/approve

@bipuladh
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Dec 16, 2024
@SanjalKatiyar
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alfonsomthd, bipuladh, GowthamShanmugam, SanjalKatiyar, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cc633ec into red-hat-storage:release-4.15 Dec 16, 2024
6 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 16, 2024 •
edited by openshift-ci bot
Loading

@alfonsomthd: [Jira Issue DFBUGS-922](https://issues.redhat.com//browse/DFBUGS-922): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-922](https://issues.redhat.com//browse/DFBUGS-922) has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/DFBUGS-922

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GowthamShanmugam GowthamShanmugam GowthamShanmugam approved these changes

@SanjalKatiyar SanjalKatiyar Awaiting requested review from SanjalKatiyar

@bipuladh bipuladh Awaiting requested review from bipuladh

Assignees

@GowthamShanmugam GowthamShanmugam

@SanjalKatiyar SanjalKatiyar

@bipuladh bipuladh

Labels
approved jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alfonsomthd @openshift-ci-robot @SanjalKatiyar @GowthamShanmugam @vbnrh @bipuladh @openshift-merge-robot