Fix activity message issue for the application deployed #1052
Conversation
|
@GowthamShanmugam Please review |
|
|
|
/hold |
TimothyAsirJeyasing
force-pushed
the
activity-should-not-unknown-on-DR-successfull
branch
from
e9f98ab to
4684ba1
Compare
| @@ -49,6 +49,15 @@ const getCurrentActivity = ( | |||
| currentStatus, | |||
| failoverCluster, | |||
| }); | |||
| } else if ( | |||
| [DRPC_STATUS.Deployed, DRPC_STATUS.Deployed].includes( | |||
There was a problem hiding this comment.
Aren't these two the same?
There was a problem hiding this comment.
yes, will fix this
TimothyAsirJeyasing
force-pushed
the
activity-should-not-unknown-on-DR-successfull
branch
from
4684ba1 to
ec86b2f
Compare
|
/retest |
TimothyAsirJeyasing
force-pushed
the
activity-should-not-unknown-on-DR-successfull
branch
from
ec86b2f to
3853fec
Compare
|
Please fix the build tests |
|
/retest |
https://bugzilla.redhat.com/show_bug.cgi?id=2234382 Signed-off-by: Timothy Asir Jeyasingh <[email protected]>
TimothyAsirJeyasing
force-pushed
the
activity-should-not-unknown-on-DR-successfull
branch
from
3853fec to
2c2937a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, TimothyAsirJeyasing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@GowthamShanmugam are we blocking this PR for some reason ?? |
|
is this ever discussed with UX @TimothyAsirJeyasing ?? |
|
/lgtm cancel |
|
/approve cancel |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Please close this PR, i think BZ is already closed for this |
|
We can close this BZ |
|
@TimothyAsirJeyasing: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://bugzilla.redhat.com/show_bug.cgi?id=2234382