-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change raw capacity tool tips message #1051
Change raw capacity tool tips message #1051
Conversation
@SanjalKatiyar Please review |
please check with UX team... |
also, I can see need_info on the BZ, plz get those things resolved and clarified... |
ad40960
to
7c9b132
Compare
/hold
|
Its for the for entire cluster capacity |
The raw capacity of a pool is for that particular pool and not for all pools. Please update the text accordingly. |
After discussing with Eran and the team, the UX team has proposed a text change that has also received approval from the Doc team. The suggestion is to modify the text to: "Raw capacity shows the total physical capacity from all the storage pools in the storage system." |
7c9b132
to
5cada94
Compare
locales/en/plugin__odf-console.json
Outdated
@@ -359,7 +359,7 @@ | |||
"Mirroring": "Mirroring", | |||
"Show image states": "Show image states", | |||
"Last checked": "Last checked", | |||
"Raw Capacity shows the total physical capacity from all storage media within the storage subsystem": "Raw Capacity shows the total physical capacity from all storage media within the storage subsystem", | |||
"Raw capacity shows the total physical capacity from all the storage pools in the storage system.": "Raw capacity shows the total physical capacity from all the storage pools in the storage system.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Raw capacity shows the total physical capacity from all the storage pools in the storage system.": "Raw capacity shows the total physical capacity from all the storage pools in the storage system.", | |
"Raw capacity shows the total physical capacity from all the storage pools in the StorageSystem.": "Raw capacity shows the total physical capacity from all the storage pools in the storage system.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
https://bugzilla.redhat.com/show_bug.cgi?id=2237895 Signed-off-by: Timothy Asir Jeyasingh <[email protected]>
5cada94
to
083b616
Compare
/cherry-pick release-4.15 |
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.15-compatibility |
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.15-compatibility in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, TimothyAsirJeyasing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0b4eee1
into
red-hat-storage:master
@SanjalKatiyar: new pull request created: #1172 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@SanjalKatiyar: new pull request created: #1173 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=2237895