Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change raw capacity tool tips message #1051

Conversation

TimothyAsirJeyasing
Copy link
Contributor

@TimothyAsirJeyasing
Copy link
Contributor Author

@SanjalKatiyar Please review

@SanjalKatiyar
Copy link
Collaborator

@SanjalKatiyar Please review

please check with UX team...

@SanjalKatiyar
Copy link
Collaborator

@SanjalKatiyar Please review

please check with UX team...

also, I can see need_info on the BZ, plz get those things resolved and clarified...

@SanjalKatiyar
Copy link
Collaborator

SanjalKatiyar commented Oct 9, 2023

/hold

  1. check whether the capacity that we show on the block-pool card is for entire cluster capacity (absolute, including storage needed for replication) or the usable/requested one ?
  2. If it is usable/requested then, check https://bugzilla.redhat.com/show_bug.cgi?id=2185042#c17 and confirm if we need to change the name of the card as well or not, "Raw" word at other places is associated with entire storage (not just usable), if so is it okay to use that term here ?

@TimothyAsirJeyasing
Copy link
Contributor Author

Its for the for entire cluster capacity

@bipuladh
Copy link
Contributor

The raw capacity of a pool is for that particular pool and not for all pools. Please update the text accordingly.

@TimothyAsirJeyasing
Copy link
Contributor Author

TimothyAsirJeyasing commented Jan 17, 2024

After discussing with Eran and the team, the UX team has proposed a text change that has also received approval from the Doc team. The suggestion is to modify the text to: "Raw capacity shows the total physical capacity from all the storage pools in the storage system."

@@ -359,7 +359,7 @@
"Mirroring": "Mirroring",
"Show image states": "Show image states",
"Last checked": "Last checked",
"Raw Capacity shows the total physical capacity from all storage media within the storage subsystem": "Raw Capacity shows the total physical capacity from all storage media within the storage subsystem",
"Raw capacity shows the total physical capacity from all the storage pools in the storage system.": "Raw capacity shows the total physical capacity from all the storage pools in the storage system.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Raw capacity shows the total physical capacity from all the storage pools in the storage system.": "Raw capacity shows the total physical capacity from all the storage pools in the storage system.",
"Raw capacity shows the total physical capacity from all the storage pools in the StorageSystem.": "Raw capacity shows the total physical capacity from all the storage pools in the storage system.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@SanjalKatiyar
Copy link
Collaborator

/cherry-pick release-4.15

@openshift-cherrypick-robot

@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SanjalKatiyar
Copy link
Collaborator

/cherry-pick release-4.15-compatibility

@openshift-cherrypick-robot

@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.15-compatibility in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SanjalKatiyar
Copy link
Collaborator

/hold cancel

Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0b4eee1 into red-hat-storage:master Jan 18, 2024
6 checks passed
@openshift-cherrypick-robot

@SanjalKatiyar: new pull request created: #1172

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@SanjalKatiyar: new pull request created: #1173

In response to this:

/cherry-pick release-4.15-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants