Added required field check in wizard flow #1039

GowthamShanmugam · 2023-09-07T13:17:23Z

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2236436

GowthamShanmugam · 2023-09-11T10:52:08Z

Screencast.from.2023-09-12.15-46-00.webm

SanjalKatiyar · 2023-09-12T05:29:29Z

packages/mco/components/modals/app-manage-policies/assign-policy-view.tsx

-      setStepIdReached(stepIdReached < id ? id : stepIdReached);
-    }
-  };
+  const [isValidationEnabled, setEnableValidation] = React.useState(false);


nits:

Suggested change

const [isValidationEnabled, setEnableValidation] = React.useState(false);

const [isValidationEnabled, setIsValidationEnabled] = React.useState(false);

SanjalKatiyar · 2023-09-12T05:39:22Z

packages/mco/components/modals/app-manage-policies/helper/assign-policy-view-footer.tsx

+    setEnableValidation(true);
+    if (canJumpToNext) {
+      setStepIdReached(stepIdReached <= stepId ? stepId + 1 : stepIdReached);
+      onNext();
+      setEnableValidation(false);
+    }


Suggested change

setEnableValidation(true);

if (canJumpToNext) {

setStepIdReached(stepIdReached <= stepId ? stepId + 1 : stepIdReached);

onNext();

setEnableValidation(false);

}

if (canJumpToNext) {

setStepIdReached(stepIdReached <= stepId ? stepId + 1 : stepIdReached);

onNext();

setEnableValidation(false);

} else setEnableValidation(true);

SanjalKatiyar · 2023-09-12T05:48:09Z

packages/mco/components/modals/app-manage-policies/helper/pvc-details-wizard-content.tsx

+        hasNoPaddingTop
+        isRequired
+        validated={
+          isValidationEnabled && !selectedLabels?.length ? 'error' : 'default'


can we create a small util function for mco ?
const getValidatedProp = (error: boolean) => error ? 'error' : 'default';

PF also have a constant variable/enum for 'error' & 'default', we can use that directly...

SanjalKatiyar · 2023-09-12T05:51:00Z

packages/mco/components/modals/app-manage-policies/helper/assign-policy-view-footer.tsx

+
+const isPVCSelectorFound = (dataPolicy: DRPolicyType) =>
+  !!dataPolicy?.placementControlInfo?.length &&
+  !!dataPolicy?.placementControlInfo?.every(


Suggested change

!!dataPolicy?.placementControlInfo?.every(

!!dataPolicy.placementControlInfo.every(

if !!dataPolicy?.placementControlInfo?.length is true then only we will reach to next condition... and if that is happening it means all fields are present...

SanjalKatiyar · 2023-09-12T05:52:24Z

packages/mco/components/modals/app-manage-policies/helper/assign-policy-view-footer.tsx

+const isPVCSelectorFound = (dataPolicy: DRPolicyType) =>
+  !!dataPolicy?.placementControlInfo?.length &&
+  !!dataPolicy?.placementControlInfo?.every(
+    (drpc) => !!drpc?.pvcSelector?.length


Suggested change

(drpc) => !!drpc?.pvcSelector?.length

(drpc) => !!drpc.pvcSelector?.length

Signed-off-by: Gowtham Shanmugasundaram <[email protected]>

openshift-ci · 2023-09-13T12:03:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GowthamShanmugam, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [SanjalKatiyar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SanjalKatiyar · 2023-09-13T12:04:00Z

/cherry-pick release-4.14

openshift-cherrypick-robot · 2023-09-13T12:04:01Z

@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SanjalKatiyar · 2023-09-13T12:04:06Z

/cherry-pick release-4.14-compatibility

openshift-cherrypick-robot · 2023-09-13T12:04:08Z

@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.14-compatibility in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SanjalKatiyar · 2023-09-13T12:05:38Z

packages/mco/components/modals/app-manage-policies/assign-policy-view.tsx

@@ -141,7 +128,7 @@ export const AssignPolicyView: React.FC<AssignPolicyViewProps> = ({
    };
    // assign DRPolicy
    const promises = assignPromises(state.policy);
-    Promise.all(promises)
+    await Promise.all(promises)


not needed... still not blocking the PR for this small nit...

Suggested change

await Promise.all(promises)

Promise.all(promises)

openshift-cherrypick-robot · 2023-09-13T12:10:09Z

@SanjalKatiyar: new pull request created: #1044

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-09-13T12:10:48Z

@SanjalKatiyar: new pull request created: #1045

In response to this:

/cherry-pick release-4.14-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GowthamShanmugam force-pushed the bz_2236436 branch from 9183620 to de21e4a Compare September 11, 2023 10:44

GowthamShanmugam changed the title ~~Added required field check in wizard flow - WIP~~ Added required field check in wizard flow Sep 11, 2023

GowthamShanmugam force-pushed the bz_2236436 branch 2 times, most recently from 292b117 to 8973ca2 Compare September 12, 2023 05:41

SanjalKatiyar requested changes Sep 12, 2023

View reviewed changes

openshift-ci bot assigned SanjalKatiyar Sep 12, 2023

Added required field check in wizard flow

0090f7d

Signed-off-by: Gowtham Shanmugasundaram <[email protected]>

GowthamShanmugam force-pushed the bz_2236436 branch from 8973ca2 to 0090f7d Compare September 12, 2023 10:10

SanjalKatiyar approved these changes Sep 13, 2023

View reviewed changes

openshift-ci bot added the lgtm label Sep 13, 2023

openshift-ci bot added the approved label Sep 13, 2023

SanjalKatiyar reviewed Sep 13, 2023

View reviewed changes

openshift-merge-robot merged commit 4cdc53a into red-hat-storage:master Sep 13, 2023
3 checks passed

openshift-cherrypick-robot mentioned this pull request Sep 13, 2023

Bug 2236436: [release-4.14] Added required field check in wizard flow #1044

Merged

openshift-cherrypick-robot mentioned this pull request Sep 13, 2023

Bug 2236436: [release-4.14-compatibility] Added required field check in wizard flow #1045

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added required field check in wizard flow #1039

Added required field check in wizard flow #1039

GowthamShanmugam commented Sep 7, 2023

GowthamShanmugam commented Sep 11, 2023 •

edited

Loading

SanjalKatiyar Sep 12, 2023

SanjalKatiyar Sep 12, 2023

SanjalKatiyar Sep 12, 2023

SanjalKatiyar Sep 12, 2023 •

edited

Loading

SanjalKatiyar Sep 12, 2023

SanjalKatiyar Sep 12, 2023

GowthamShanmugam Sep 12, 2023

SanjalKatiyar Sep 12, 2023

openshift-ci bot commented Sep 13, 2023

SanjalKatiyar commented Sep 13, 2023

openshift-cherrypick-robot commented Sep 13, 2023

SanjalKatiyar commented Sep 13, 2023

openshift-cherrypick-robot commented Sep 13, 2023

SanjalKatiyar Sep 13, 2023

openshift-cherrypick-robot commented Sep 13, 2023

openshift-cherrypick-robot commented Sep 13, 2023

	const [isValidationEnabled, setEnableValidation] = React.useState(false);
	const [isValidationEnabled, setIsValidationEnabled] = React.useState(false);

	!!dataPolicy?.placementControlInfo?.every(
	!!dataPolicy.placementControlInfo.every(

	(drpc) => !!drpc?.pvcSelector?.length
	(drpc) => !!drpc.pvcSelector?.length

Added required field check in wizard flow #1039

Added required field check in wizard flow #1039

Conversation

GowthamShanmugam commented Sep 7, 2023

GowthamShanmugam commented Sep 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjalKatiyar Sep 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci bot commented Sep 13, 2023

SanjalKatiyar commented Sep 13, 2023

openshift-cherrypick-robot commented Sep 13, 2023

SanjalKatiyar commented Sep 13, 2023

openshift-cherrypick-robot commented Sep 13, 2023

Choose a reason for hiding this comment

openshift-cherrypick-robot commented Sep 13, 2023

openshift-cherrypick-robot commented Sep 13, 2023

GowthamShanmugam commented Sep 11, 2023 •

edited

Loading

SanjalKatiyar Sep 12, 2023 •

edited

Loading