Skip to content

Commit

Permalink
Merge pull request #1206 from SanjalKatiyar/fix_ns_publish_shared
Browse files Browse the repository at this point in the history
Fix i18n NS ref in shared + publish new version
  • Loading branch information
openshift-merge-bot[bot] authored Feb 5, 2024
2 parents f4288a5 + ea930d5 commit a36fa00
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 12 deletions.
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@odf-console/shared",
"description": "ODF console shared code.",
"version": "0.0.0-beta12",
"version": "0.0.0-beta13",
"license": "Apache-2.0",
"private": false,
"main": "src/index.ts",
Expand Down
4 changes: 1 addition & 3 deletions packages/shared/src/details-page/datetime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,7 @@ export const fromNow = (dateTime: string | Date, now?: Date, options?) => {

const d = new Date(dateTime);
const ms = now.getTime() - d.getTime();
const justNow = i18n.t('plugin__odf-console~Just now', {
ns: 'plugin__odf-console',
});
const justNow = i18n.t('Just now');

// If the event occurred less than one minute in the future, assume it's clock drift and show "Just now."
if (!options?.omitSuffix && ms < 60000 && ms > maxClockSkewMS) {
Expand Down
8 changes: 1 addition & 7 deletions packages/shared/src/text-inputs/password-input.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,7 @@ const PasswordInput: React.FC<PasswordInputProps> = ({
onChange={onChange}
isRequired={isRequired}
/>
<Tooltip
content={
showPassword
? t('plugin__odf-console~Hide password')
: t('plugin__odf-console~Show password')
}
>
<Tooltip content={showPassword ? t('Hide password') : t('Show password')}>
<Button
variant="control"
onClick={() => setShowPassword(!showPassword)}
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@
rimraf "^3.0.2"

"@odf/shared@file:packages/shared":
version "0.0.0-beta12"
version "0.0.0-beta13"
dependencies:
"@patternfly/patternfly" "4.103.6"
"@patternfly/react-charts" "^6.15.3"
Expand Down

0 comments on commit a36fa00

Please sign in to comment.