filesystem: correct the pool name in the ux backend handler #2924
Conversation
In the expandstorage handler pool name is incorrect, Rook adds the filesystemName prefix to every datapool, which was missing in the storageclass parameter https://github.com/rook/rook/blob/44e96c8ab67a27121354a04b121b7f16b6a38894/pkg/operator/ceph/file/filesystem.go#L321 Signed-off-by: parth-gr <[email protected]>
parth-gr
force-pushed
the
fix-ux-device-class
branch
from
0b660d8 to
3396a61
Compare
|
/cherry-pick 4.18 |
|
@parth-gr: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
assigned iamniting, Madhu-1, malayparida2000, SanjalKatiyar and travisn
| @@ -268,7 +268,7 @@ func createCephFilesystemStorageClass(w http.ResponseWriter, r *http.Request, cl | |||
| Parameters: map[string]string{ | |||
| "clusterID": namespace, | |||
| "fsName": filesystemName, | |||
| "pool": poolName, | |||
| "pool": fmt.Sprintf("%s-%s", filesystemName, poolName), | |||
There was a problem hiding this comment.
is pool name mandatory when we expand the storage? if not Rook appends different value with integers
There was a problem hiding this comment.
Yaa in the UI the pool name is mandatory,
cc @SanjalKatiyar to keep me honest
There was a problem hiding this comment.
in that case lets make it mandatory here(HTTP request) as well
There was a problem hiding this comment.
yeah, UI has it as a mandatory field.
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, parth-gr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit 7d2b735
into
red-hat-storage:main
|
@parth-gr: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.18 |
|
@parth-gr: new pull request created: #2928 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In the expandstorage handler pool name is incorrect,
Rook adds the filesystemName prefix to every datapool, which was missing in the storageclass parameter
https://github.com/rook/rook/blob/44e96c8ab67a27121354a04b121b7f16b6a38894/pkg/operator/ceph/file/filesystem.go#L321