Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services: remove Getter as they generated as part of proto #2856

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

services: remove Getter as they generated as part of proto #2856

wants to merge 1 commit into from

Conversation

rchikatw
Copy link
Contributor

  • remove Getter as they are generated as part of proto
  • not removing GetPlatformVersion() & GetOperatorVersion() as they are already used. Leela will take care of removing this.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rchikatw
Once this PR has been reviewed and has the lgtm label, please assign iamniting for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rchikatw rchikatw force-pushed the addspecstorageconsumer branch 2 times, most recently from 68867da to 000fb1d Compare October 23, 2024 05:32
leelavg
leelavg reviewed Oct 23, 2024
View reviewed changes
services/provider/server/consumer.go
@@ -207,7 +208,7 @@ func (c *ocsConsumerManager) Get(ctx context.Context, id string) (*ocsv1alpha1.S
return consumerObj, nil
}

func (c *ocsConsumerManager) UpdateConsumerStatus(ctx context.Context, id string, status ifaces.StorageClientStatus) error {
func (c *ocsConsumerManager) UpdateConsumerStatus(ctx context.Context, id string, status *pb.ReportStatusRequest) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this being changed? the whole point was to abstract ReportStatusRequest as it keeps on increasing and keep on satisfying StorageClientStatus interface.

services/provider/api/interfaces/interfaces.go Outdated
Comment on lines 8 to 13
GetOperatorVersion() string
GetClusterID() string
GetClusterName() string
GetClientName() string
GetStorageQuotaUtilizationRatio() float64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change the comment to

These two getters are redirects for generated protobuf rpcs' and only add new getters here if you want to use different names which is not encouraged as these two are here only for backward compatibility

you can find setters at services/provider/api/storageclient.go and generated getters at services/provider/api/provider.pb.go

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2024
@openshift-merge-bot @rchikatw
Merge pull request red-hat-storage#2930 from rewantsoni/fix-server
384859e 
provider: provide namespace for storage-client-mapping config
Signed-off-by: rchikatw <[email protected]>
@rchikatw rchikatw force-pushed the addspecstorageconsumer branch from 000fb1d to 384859e Compare December 9, 2024 07:40
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2024
@rchikatw
Copy link
Contributor Author

rchikatw commented Dec 9, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

@rchikatw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-bundle-ocs-operator-bundle 384859e link true /test ci-bundle-ocs-operator-bundle
ci/prow/ocs-operator-bundle-e2e-aws 384859e link true /test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leelavg leelavg leelavg left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rchikatw @leelavg @openshift-merge-robot