Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate odf-info structs to API folder #2698

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

raaizik
Copy link
Contributor

@raaizik raaizik commented Jul 16, 2024

Changes

Converts odf-info structs into its own API
#2440

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@raaizik raaizik force-pushed the odf-info_fixes branch 3 times, most recently from 3521454 to d80d75f Compare July 16, 2024 10:05
@raaizik raaizik marked this pull request as ready for review July 16, 2024 10:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
@raaizik
Copy link
Contributor Author

raaizik commented Jul 16, 2024

/cc @umangachapagain @nb-ohad

@rewantsoni
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@nb-ohad
Copy link
Contributor

nb-ohad commented Jul 16, 2024

A couple of points:

  • As suggested by @umangachapagain in an offline discussion. A better name for the file containing the new type would be odfinfo_config.go. Mainly because the _type suffix is usually reserved for k8s API types.
  • This is a new API and we have no indication of its stability. It is better we have it in the v1alpha1 folder
  • The second commit seems unrelated to this change and I would request to separate it into its own PR

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@raaizik
Copy link
Contributor Author

raaizik commented Jul 16, 2024

A couple of points:

* As suggested by @umangachapagain in an offline discussion. A better name for the file containing the new type would be `odfinfo_config.go`. Mainly because the `_type` suffix is usually reserved for k8s API types.

* This is a new API and we have no indication of its stability. It is better we have it in the v1alpha1 folder

* The second commit seems unrelated to this change and I would request to separate it into its own PR

Done @nb-ohad

@raaizik
Copy link
Contributor Author

raaizik commented Jul 16, 2024

/test ocs-operator-bundle-e2e-aws

@nb-ohad
Copy link
Contributor

nb-ohad commented Jul 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, raaizik, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b124494 into red-hat-storage:main Jul 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants