Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert rgw vhost dnsnames feature #2666

Conversation

BlaineEXE
Copy link
Contributor

Revert commits from PRs #2544 and #2515 as a fix for BZ 2283643. This PR will need backported to the 4.16 release branch.

It was decided to revert this feature since a fix might not be done by the time release can be completed. Full context and discussions: https://bugzilla.redhat.com/show_bug.cgi?id=2283643#c44

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
Revert "Bug 2273553: initalise objectstore.spec.hosting for virtualHostnames"

This reverts commit f9d3ce8.
This reverts commit 1098627.

Signed-off-by: Blaine Gardner <[email protected]>
@BlaineEXE BlaineEXE force-pushed the revert-rgw-vhost-dnsnames-feature branch from 00e95d0 to 2509d98 Compare June 14, 2024 17:30
@BlaineEXE BlaineEXE requested review from iamniting and malayparida2000 and removed request for iamniting June 14, 2024 20:11
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2024
@iamniting
Copy link
Member

/cherry-pick release-4.16

Copy link
Contributor

openshift-ci bot commented Jun 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlaineEXE, iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BlaineEXE,iamniting]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit cf0f728 into red-hat-storage:main Jun 15, 2024
11 checks passed
@openshift-cherrypick-robot

@iamniting: new pull request created: #2667

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BlaineEXE BlaineEXE deleted the revert-rgw-vhost-dnsnames-feature branch June 17, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants