Sends VolumeGroupSnapshotClass to client
#2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raaizik
force-pushed
the
RHSTOR-5795
branch
3 times, most recently
from
4bebb4c to
652e5f1
Compare
|
/cc @rewantsoni |
|
/cc @Madhu-1 |
leelavg
approved these changes
Jun 13, 2024
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold for a sec I thought ocs-client-op repo and put a hold. |
openshift-ci
bot
removed
the
do-not-merge/hold
2 tasks
Madhu-1
reviewed
Jun 17, 2024
nb-ohad
requested changes
Jun 20, 2024
|
/retest |
Madhu-1
suggested changes
Jul 1, 2024
|
/lgtm |
openshift-ci
bot
added
the
approved
|
@raaizik can you please check why the e2e test failed? |
Signed-off-by: raaizik <[email protected]>
|
/test ocs-operator-bundle-e2e-aws |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, Madhu-1, nb-ohad, raaizik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit fbe323d
into
red-hat-storage:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sends
VolumeGroupSnapshotClassas an external resource to the client via the storage claim response.Must be merged prior to ocs-client-operator/pull/168.
RHSTOR-5795