-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storagecluster version in odfinfoconfig unit test #2619
Fix storagecluster version in odfinfoconfig unit test #2619
Conversation
09f1c19
to
ee26859
Compare
Update storagcluster version in odfinfoconfig test to fetch the current ocs version dynamically Signed-off-by: Nikhil-Ladha <[email protected]>
ee26859
to
88bfcf0
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, Nikhil-Ladha, raaizik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Pasting relevant comment. @Nikhil-Ladha, I tend to agree as as mentioned in my first comment this data is better off as a dummy. |
The e2e is failing due to ocs-client-operator installation failing |
/retest |
Technically, it is not a dummy value. But, a hardcoded value that would change in each release. |
But IMO this type of data should be treated as a mock in tests and not in a way that stores its real value. |
It should be, but in the part of code that this test is testing out, we can't set version to a mock value, since it is comparing the value with an actual storagecluster that is created in the test env. |
c92a7d9
into
red-hat-storage:main
Update storagcluster version in odfinfoconfig test to 4.17