Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storagecluster version in odfinfoconfig unit test #2619

Merged

Conversation

Nikhil-Ladha
Copy link
Member

Update storagcluster version in odfinfoconfig test to 4.17

@Nikhil-Ladha Nikhil-Ladha requested a review from iamniting May 20, 2024 06:38
@Nikhil-Ladha Nikhil-Ladha mentioned this pull request May 20, 2024
3 tasks
Update storagcluster version in odfinfoconfig test to fetch
the current ocs version dynamically

Signed-off-by: Nikhil-Ladha <[email protected]>
@Nikhil-Ladha Nikhil-Ladha requested a review from raaizik May 20, 2024 09:11
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, Nikhil-Ladha, raaizik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nikhil-Ladha
Copy link
Member Author

/retest

@raaizik
Copy link
Contributor

raaizik commented May 20, 2024

Pasting relevant comment. @Nikhil-Ladha, I tend to agree as as mentioned in my first comment this data is better off as a dummy.

@malayparida2000
Copy link
Contributor

The e2e is failing due to ocs-client-operator installation failing

@Nikhil-Ladha
Copy link
Member Author

/retest

@Nikhil-Ladha
Copy link
Member Author

Pasting relevant comment. @Nikhil-Ladha, I tend to agree as as mentioned in my first comment this data is better off as a dummy.

Technically, it is not a dummy value. But, a hardcoded value that would change in each release.

@raaizik
Copy link
Contributor

raaizik commented May 20, 2024

Pasting relevant comment. @Nikhil-Ladha, I tend to agree as as mentioned in my first comment this data is better off as a dummy.

Technically, it is not a dummy value. But, a hardcoded value that would change in each release.

But IMO this type of data should be treated as a mock in tests and not in a way that stores its real value.

@Nikhil-Ladha
Copy link
Member Author

Pasting relevant comment. @Nikhil-Ladha, I tend to agree as as mentioned in my first comment this data is better off as a dummy.

Technically, it is not a dummy value. But, a hardcoded value that would change in each release.

But IMO this type of data should be treated as a mock in tests and not in a way that stores its real value.

It should be, but in the part of code that this test is testing out, we can't set version to a mock value, since it is comparing the value with an actual storagecluster that is created in the test env.

@openshift-merge-bot openshift-merge-bot bot merged commit c92a7d9 into red-hat-storage:main May 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants