add ROOK_OBC_PROVISIONER_NAME_PREFIX to Rook Config #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamniting
requested changes
Mar 18, 2024
thotz
force-pushed
the
obc-driver-prefix-storage-class
branch
from
98a17f0 to
b231a30
Compare
iamniting
requested changes
Mar 18, 2024
| @@ -3247,6 +3247,8 @@ spec: | |||
| fieldPath: metadata.namespace | |||
| - name: ROOK_OBC_WATCH_OPERATOR_NAMESPACE | |||
| value: "true" | |||
| - name: ROOK_OBC_PROVISIONER_NAME_PREFIX | |||
There was a problem hiding this comment.
Can you pls remove this change?
Similar to CSI_DRIVER_NAME_PREFIX for obc provisioner so that the obc provisioner always checks for storageclass with name `openshift-storage.ceph.rook.io/bucket` Signed-off-by: Jiffin Tony Thottan <[email protected]>
thotz
force-pushed
the
obc-driver-prefix-storage-class
branch
from
b231a30 to
cba19a5
Compare
|
/test ocs-operator-bundle-e2e-aws |
iamniting
approved these changes
Mar 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, thotz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test ocs-operator-bundle-e2e-aws |
2 similar comments
|
/test ocs-operator-bundle-e2e-aws |
|
/test ocs-operator-bundle-e2e-aws |
openshift-merge-bot
bot
merged commit bd08bf5
into
red-hat-storage:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to CSI_DRIVER_NAME_PREFIX for obc provisioner so that the obc provisioner always checks for storageclass with name
openshift-storage.ceph.rook.io/bucket