Update rook api and image to latest version and also updated the default service account in toolbox pod #2507
Conversation
Nikhil-Ladha
commented
Mar 14, 2024
•
Nikhil-Ladha
commented
- Updated rook api, image to latest version
- We are now using latest downstream rook image, i.e, red-hat-storage/rook since we are now actively maintaining the downstream fork and there are some downstream only changes that is required for the ocs-operator to run properly.
- Updated the code to use VolumeClaimTemplate instead of PersistentVolumeClaim
- Added default service account for toolbox pod, as the rook scc is now updated and the default service account is removed.
Nikhil-Ladha
force-pushed
the
update-rook-apis
branch
2 times, most recently
from
e93a37d to
26d38af
Compare
There was a problem hiding this comment.
@Nikhil-Ladha Can you pls remove the struct changes for now, The CI is failing because we don't have go.work file in the CI and we can not create it due to DS build tools.
Nikhil-Ladha
force-pushed
the
update-rook-apis
branch
6 times, most recently
from
3651d63 to
550396b
Compare
openshift-ci
bot
added
lgtm
|
/test ocs-operator-bundle-e2e-aws |
1 similar comment
|
/test ocs-operator-bundle-e2e-aws |
|
We would probably need to update the rook image as well, better to do it once we have Travis's PR merged. |
Nikhil-Ladha
force-pushed
the
update-rook-apis
branch
from
1ccc581 to
a2600e4
Compare
Nikhil-Ladha
force-pushed
the
update-rook-apis
branch
from
a2600e4 to
da61836
Compare
|
@Nikhil-Ladha we dont need the upstream PR, but we have a separate pr for downstream #2511 So if this is all done can we merge it |
|
@parth-gr: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR is all set, we are having issues with CI that's the reason the PR is not merged. |
|
/retest |
Nikhil-Ladha
changed the title
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test ocs-operator-bundle-e2e-aws |
|
/test ocs-operator-bundle-e2e-aws |
|
@Nikhil-Ladha Can you pls take a look at the CI failure? I just restarted it. It will take half an hour to deploy the setup. pls do keep an eye on it. |
|
/retest |
1 similar comment
|
/retest |
Nikhil-Ladha
force-pushed
the
update-rook-apis
branch
from
7a1d10a to
a338604
Compare
Update rook api and image to latest version. Also, started using rook downstream image i.e, red-hat-storage/rook image to include downstream only changes for rook Signed-off-by: Nikhil-Ladha <[email protected]>
Update VolumeClaimTemplate and VolumeResourceRequirements api changes Signed-off-by: Nikhil-Ladha <[email protected]>
Add generated changes for rook api and image update Signed-off-by: Nikhil-Ladha <[email protected]>
Nikhil-Ladha
force-pushed
the
update-rook-apis
branch
from
a338604 to
eb4fdae
Compare
Nikhil-Ladha
changed the title
Currently rook scc are updated to remove the k8s default service account, so toolbox should start with rook-ceph-default service account Signed-off-by: Nikhil-Ladha <[email protected]> Co-authored-by: parth-gr <[email protected]>
Nikhil-Ladha
force-pushed
the
update-rook-apis
branch
from
eb4fdae to
30b9ef3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, Nikhil-Ladha, parth-gr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/override ci/prow/ci-bundle-ocs-operator-bundle The CI is passed once, no need to run it again |
|
@iamniting: Overrode contexts on behalf of iamniting: ci/prow/ci-bundle-ocs-operator-bundle In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/ocs-operator-bundle-e2e-aws |
|
@iamniting: Overrode contexts on behalf of iamniting: ci/prow/ocs-operator-bundle-e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/images |
|
@iamniting: Overrode contexts on behalf of iamniting: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-bot
bot
merged commit 16f3414
into
red-hat-storage:main
