Apply custom taints via the storagecluster CR #2502
Conversation
iamniting
requested review from
travisn,
umangachapagain,
Nikhil-Ladha and
malayparida2000
openshift-ci
bot
added
the
approved
iamniting
force-pushed
the
tolerations
branch
3 times, most recently
from
31503fe to
bcdbc57
Compare
|
@iamniting just curious, I saw the comments were resolved w/ responses, should the PR author close it or the one who reviewed? Btw, I'm not in reviewers list and reviewed PR on a request from @nb-ohad, pls excuse. |
Anyone can resolve that if they think the conversation is done.
That's okay, Ohad told me you will take a look. We don't believe that only reviewers in the list need to review anyone can come and review and provide their input. |
iamniting
force-pushed
the
tolerations
branch
3 times, most recently
from
d5c3cdd to
8b7cfbd
Compare
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
Introduce a new status field to track addition of tolerations in the rook-ceph-operator-config configmap. The added field status indicates whether tolerations were successfully added to the configmap. This information is crucial for ensuring safe deletion, as we will only proceed with deletion if the tolerations were added by our mechanism. If they were added by user we will not proceed with the deletion. Signed-off-by: Nitin Goyal <[email protected]>
Enhance the configuration process by incorporating CSI tolerations directly into the rook-ceph-operator-config configmap through the controller. Previously, end users were required to manually edit the configmap for adding CSI tolerations. With this update, users can now seamlessly include CSI tolerations in the storage clusters, and the ocs-operator will automatically propagate these tolerations to the configmap. This improvement simplifies the configuration workflow and ensures that CSI tolerations are seamlessly applied to the Rook Ceph Operator without the need for manual intervention in the configmap. Signed-off-by: Nitin Goyal <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 50bd4ef
into
red-hat-storage:main
Signed-off-by: Nitin Goyal [email protected]