controllers: use k8s pointer util #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
jarrpa
force-pushed
the
jarrpa/pointer-vars
branch
2 times, most recently
from
56038dc to
28087c3
Compare
leelavg
reviewed
Jan 30, 2024
tools/csv-merger/csv-merger.go
Outdated
| @@ -926,7 +927,6 @@ func copyManifests() { | |||
|
|
|||
| func getUXBackendServerDeployment() appsv1.DeploymentSpec { | |||
| replica := int32(1) | |||
| ptrToTrue := true | |||
| deployment := appsv1.DeploymentSpec{ | |||
| Replicas: &replica, | |||
There was a problem hiding this comment.
possibly another candidate?
openshift-merge-robot
added
the
needs-rebase
jarrpa
force-pushed
the
jarrpa/pointer-vars
branch
from
28087c3 to
48b855b
Compare
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Jose A. Rivera <[email protected]>
jarrpa
force-pushed
the
jarrpa/pointer-vars
branch
from
48b855b to
495672f
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
leelavg
approved these changes
Feb 5, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jarrpa, leelavg, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
openshift-merge-bot
bot
merged commit 73ef95a
into
red-hat-storage:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge thanks to @malayparida2000 for finding this over a year ago. 😆
Signed-off-by: Jose A. Rivera [email protected]
Waiting on #2385