Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHSTOR-5075] remove StorageClientIncompatibleOperatorVersion alert at Critical level #2318

Closed
wants to merge 1 commit into from

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Dec 12, 2023

- This alert is initially raised if client operator is outside of
support matrix b/n ODF Provider and ODF Client
- With red-hat-storage#2308 and red-hat-storage#2311 we are enforcing the onboard and upgrade
- So, this alert can be removed now

Signed-off-by: Leela Venkaiah G <[email protected]>
Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg
Once this PR has been reviewed and has the lgtm label, please assign nb-ohad for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg
Copy link
Contributor Author

leelavg commented Dec 12, 2023

/hold

depends on #2308 and #2311 to be merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2023
@nb-ohad
Copy link
Contributor

nb-ohad commented Dec 12, 2023

@leelavg Why are we removing this? It would be helpful if by some edge case, we got to that scenario

@leelavg
Copy link
Contributor Author

leelavg commented Dec 13, 2023

@leelavg Why are we removing this? It would be helpful if by some edge case, we got to that scenario

  • ack, I was also in cross-roads to remove this or not, I do agree to have this. I'm closing this PR and corresponding Jira.

@leelavg leelavg closed this Dec 13, 2023
@leelavg leelavg deleted the 5075-remove-alert branch December 13, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants