Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update direct dependencies like rook,noobaa,openshift,operator framework & others #2315

Merged

Conversation

malayparida2000
Copy link
Contributor

No description provided.

@malayparida2000
Copy link
Contributor Author

/test ocs-operator-bundle-e2e-aws

@df-build-team df-build-team requested a review from a team December 11, 2023 11:48
Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
This should be merged later unless this is blocking a feature.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 11, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash the first 2 commits, since 1st commit won't work without the 2nd.

@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 18, 2023
Also include go mod tidy && go mod vendor changes for both the main
module & the api module.

Signed-off-by: Malay Kumar Parida <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2023
@malayparida2000 malayparida2000 changed the title Update direct dependencies & Update images used for CSV generation Update direct dependencies like rook,noobaa,openshift,operator framework & others Dec 18, 2023
Also add make gen-latest-csv changes

Signed-off-by: Malay Kumar Parida <[email protected]>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: malayparida2000, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@umangachapagain
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 334ed88 into red-hat-storage:main Dec 18, 2023
14 checks passed
rewantsoni pushed a commit to rewantsoni/ocs-operator that referenced this pull request Dec 18, 2023
…cies

Update direct dependencies like rook,noobaa,openshift,operator framework & others
@malayparida2000 malayparida2000 deleted the dependancies branch June 11, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants