Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert user if ceph metadata server is consuming cpu at threshold point. #2307

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Alert user if ceph metadata server is consuming cpu at threshold point. #2307

merged 1 commit into from
Dec 11, 2023

Conversation

manishym
Copy link
Contributor

@manishym manishym commented Dec 6, 2023 •
edited
Loading

Raise an alert to scale active MDS pods if the CPU usage of MDS pod is more than 67% for 6 hours.

@agarwal-mudit
Copy link
Member

@aruniiird Please review

@manishym manishym force-pushed the RHSTOR-3865 branch 3 times, most recently from 67bb6ee to 43d1b07 Compare December 11, 2023 03:36
@manishym manishym requested a review from travisn December 11, 2023 03:37
umangachapagain
umangachapagain requested changes Dec 11, 2023
View reviewed changes
metrics/mixin/alerts/alerts.libsonnet Outdated Show resolved Hide resolved
metrics/mixin/alerts/perf.libsonnet Outdated Show resolved Hide resolved
metrics/mixin/alerts/perf.libsonnet Outdated Show resolved Hide resolved
metrics/mixin/config.libsonnet Show resolved Hide resolved
metrics/mixin/alerts/perf.libsonnet Show resolved Hide resolved
metrics/mixin/alerts/perf.libsonnet Outdated Show resolved Hide resolved
jmolmo
jmolmo suggested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@jmolmo jmolmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the suggestions, and do not forget to add the extended documentation file for this new alert in the runbook repo and the related annotation label with the link.
See example

metrics/mixin/config.libsonnet Show resolved Hide resolved
metrics/mixin/alerts/perf.libsonnet Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2023
@manishym
Copy link
Contributor Author

Please address the suggestions, and do not forget to add the extended documentation file for this new alert in the runbook repo and the related annotation label with the link. See example

I will address runbook changes after Feature Freeze.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2023
@manishym
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manishym, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 9512c9b into red-hat-storage:main Dec 11, 2023
15 checks passed
@manishym manishym deleted the RHSTOR-3865 branch December 11, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umangachapagain umangachapagain umangachapagain approved these changes

@travisn travisn Awaiting requested review from travisn

@jmolmo jmolmo Awaiting requested review from jmolmo

Assignees

@jmolmo jmolmo

@umangachapagain umangachapagain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@manishym @agarwal-mudit @travisn @jmolmo @umangachapagain @openshift-merge-robot