Add ClusterClaim for RDR optimizations and refactor getOsdCount() #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
umangachapagain
commented
Dec 5, 2023
| @@ -193,6 +203,26 @@ func (c *ClusterClaimCreator) getCephFsid() (string, error) { | |||
| return "", fmt.Errorf("failed to fetch ceph fsid from %q secret", RookCephMonSecretName) | |||
| } | |||
|
|
|||
| func (c *ClusterClaimCreator) getIsDROptimized(serverVersion *version.Info) (string, error) { | |||
There was a problem hiding this comment.
@sp98 Can you check if this is accurate?
umangachapagain
commented
Dec 5, 2023
iamniting
requested changes
Dec 5, 2023
There was a problem hiding this comment.
@umangachapagain The code changes looks good, Once Santosh confirm we can merge it, Can you pls fix commitlint issue before that?
sp98
reviewed
Dec 12, 2023
Signed-off-by: Umanga Chapagain <[email protected]>
Regional DR optimization status is crucial in configuring clusters for Regional DR. It is set to true when all optimizations are applied. Signed-off-by: Umanga Chapagain <[email protected]>
umangachapagain
force-pushed
the
rdr-optimizations
branch
from
e104693 to
844d522
Compare
iamniting
approved these changes
Dec 12, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@iamniting @umangachapagain Changes look good to me. |
openshift-merge-bot
bot
merged commit 9fa768c
into
red-hat-storage:main
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.