Rook api & image update to latest master #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
openshift-merge-robot
added
the
needs-rebase
malayparida2000
force-pushed
the
rook
branch
from
294f53e to
2c829ff
Compare
openshift-merge-robot
removed
the
needs-rebase
malayparida2000
force-pushed
the
rook
branch
2 times, most recently
from
4101a1a to
228cb9a
Compare
|
/retest |
malayparida2000
force-pushed
the
rook
branch
6 times, most recently
from
fa1a0e6 to
20c97b4
Compare
malayparida2000
changed the title
malayparida2000
force-pushed
the
rook
branch
from
20c97b4 to
c0b8748
Compare
malayparida2000
commented
Nov 16, 2023
malayparida2000
commented
Nov 16, 2023
malayparida2000
commented
Nov 16, 2023
umangachapagain
requested changes
Nov 16, 2023
go get github.com/rook/rook@master go get github.com/rook/rook/pkg/apis@master Also add make deps-update changes Fix breaking changes in manager due to new controller-runtime version Unit test fixes after controller-runtime update to v0.16.0 Create mock storageClusters with finalizers inside them as the fake client has issues when both status & objectmeta are updated in the same reconcile loop. Also fixed TestCreateSCCs & TestOcsProviderServerEnsureCreated tests. No longer skip the TestOCSProviderServerStorageClassRequest test. Signed-off-by: Malay Kumar Parida <[email protected]>
Also add make gen-latest-csv changes Signed-off-by: Malay Kumar Parida <[email protected]>
malayparida2000
force-pushed
the
rook
branch
from
c0b8748 to
2ee5b3a
Compare
Done |
umangachapagain
approved these changes
Nov 16, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: malayparida2000, umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit e6631e6
into
red-hat-storage:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rook api & image to latest on master.
Also add make deps-update changes
Fix breaking changes in manager due to new controller-runtime version
Unit test fixes after controller-runtime update to v0.16.0
Create mock storageClusters with finalizers inside them as the fake
client has issues when both status & objectmeta are updated in the same
reconcile loop.
Also fixed TestCreateSCCs & TestOcsProviderServerEnsureCreated tests.
No longer skip the TestOCSProviderServerStorageClassRequest test.