Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a flag to mark rbd storageclass as the default for the cluster #2222

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

malayparida2000
Copy link
Contributor

controllers/storagecluster/storageclasses.go Outdated Show resolved Hide resolved
api/v1/storagecluster_types.go Outdated Show resolved Hide resolved
controllers/storagecluster/storageclasses.go Outdated Show resolved Hide resolved
api/v1/storagecluster_types.go Outdated Show resolved Hide resolved
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@openshift-ci openshift-ci bot merged commit abd2688 into red-hat-storage:main Oct 20, 2023
6 checks passed
@malayparida2000 malayparida2000 deleted the rbd_default branch November 7, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants