Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2244517:[release-4.14] set FlappingRestartIntervalHours to 24 hrs #2219

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

sp98
Copy link
Contributor

@sp98 sp98 commented Oct 17, 2023

This PR is a manual backport of PR #2214
when FlappingRestartIntervalHours interval is set, OSD pods will start as a bash script. The script will make OSD pod to sleep for 24 hrs if the OSD daemon was stopped due to flapping of the OSDs.

https://bugzilla.redhat.com/show_bug.cgi?id=2244517
https://bugzilla.redhat.com/show_bug.cgi?id=2244566

sp98 added 3 commits October 17, 2023 18:36
Signed-off-by: sp98 <[email protected]>
(cherry picked from commit a8f25db)
update `validateMultusSelectors` function to use `map[CephNetworkType]string`
instead of `map[string]string

Signed-off-by: sp98 <[email protected]>
(cherry picked from commit 8f36536)
Signed-off-by: sp98 <[email protected]>
(cherry picked from commit 11f5873)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

@sp98: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Backport 2214: set FlappingRestartIntervalHours to 24 hrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp98 sp98 changed the title Backport 2214: set FlappingRestartIntervalHours to 24 hrs Bug 2244517: set FlappingRestartIntervalHours to 24 hrs Oct 17, 2023
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

@sp98: This pull request references Bugzilla bug 2244517, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.0) matches configured target release for branch (ODF 4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2244517: set FlappingRestartIntervalHours to 24 hrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@iamniting iamniting changed the title Bug 2244517: set FlappingRestartIntervalHours to 24 hrs Bug 2244517:[release-4.14]: set FlappingRestartIntervalHours to 24 hrs Oct 17, 2023
@iamniting iamniting changed the title Bug 2244517:[release-4.14]: set FlappingRestartIntervalHours to 24 hrs Bug 2244517:[release-4.14] set FlappingRestartIntervalHours to 24 hrs Oct 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

@sp98: This pull request references Bugzilla bug 2244517, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.0) matches configured target release for branch (ODF 4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2244517:[release-4.14] set FlappingRestartIntervalHours to 24 hrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit a3dbfeb into red-hat-storage:release-4.14 Oct 17, 2023
6 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

@sp98: All pull requests linked via external trackers have merged:

Bugzilla bug 2244517 has been moved to the MODIFIED state.

In response to this:

Bug 2244517:[release-4.14] set FlappingRestartIntervalHours to 24 hrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants