Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 2 mgr daemons by default, one active and one standby. #2217

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

malayparida2000
Copy link
Contributor

This significantly improves the reliability and eliminates the possibility of a single point of failure for the mgr service.

Jira-https://issues.redhat.com/browse/RHSTOR-4139

controllers/storagecluster/cephcluster.go Outdated Show resolved Hide resolved
api/v1/storagecluster_types.go Show resolved Hide resolved
@malayparida2000
Copy link
Contributor Author

/test ocs-operator-bundle-e2e-aws

api/v1/storagecluster_types.go Outdated Show resolved Hide resolved
api/v1/storagecluster_types.go Outdated Show resolved Hide resolved
controllers/storagecluster/cephcluster_test.go Outdated Show resolved Hide resolved
@malayparida2000 malayparida2000 force-pushed the mgr branch 2 times, most recently from a20840e to b347ae6 Compare October 19, 2023 06:11
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

controllers/storagecluster/cephcluster_test.go Outdated Show resolved Hide resolved
controllers/storagecluster/cephcluster_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a suggestion on the deprecated comment.

api/v1/storagecluster_types.go Outdated Show resolved Hide resolved
@travisn
Copy link
Contributor

travisn commented Oct 19, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also correct the filed keyword in the commit msg description.

api/v1/storagecluster_types.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
This significantly improves the reliability, and eliminates the
possibility of a single point of failure for the mgr service.
The field EnableActivePassive has been now marked as deprecated.
By default we now have 2 ceph manager pods, one active and one standby.

Signed-off-by: Malay Kumar Parida <[email protected]>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@openshift-ci openshift-ci bot merged commit f5b541b into red-hat-storage:main Oct 20, 2023
6 checks passed
@malayparida2000 malayparida2000 deleted the mgr branch November 7, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants