Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2244383: [release-4.14] Add default virtualization storage class annotation #2216

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2213

/assign agarwal-mudit

This signals to kubevirt that requests not explicitly specifying any storage class
should use this one.

Signed-off-by: Alex Kalenyuk <[email protected]>
@nixpanic
Copy link
Member

/retitle Bug 2244383: [release-4.14] Add default virtualization storage class annotation
/lgtm
/approve

@openshift-ci openshift-ci bot changed the title [release-4.14] Add default virtualization storage class annotation Bug 2244383: [release-4.14] Add default virtualization storage class annotation Oct 16, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2244383, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.0) matches configured target release for branch (ODF 4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2244383: [release-4.14] Add default virtualization storage class annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, nixpanic, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@agarwal-mudit
Copy link
Member

/retest

@agarwal-mudit agarwal-mudit merged commit f5b379c into red-hat-storage:release-4.14 Oct 16, 2023
6 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2244383 has been moved to the MODIFIED state.

In response to this:

Bug 2244383: [release-4.14] Add default virtualization storage class annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants