Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in metrics code comment #2205

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Nikhil-Ladha
Copy link
Member

Fixed typo in word collector under metrics component and make the code-spell-check CI stable

Fixed typo in word `collector` under metrics component and make the code-spell-check
CI stable

Signed-off-by: Nikhil-Ladha <[email protected]>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nbalacha, Nikhil-Ladha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@openshift-ci openshift-ci bot merged commit 70fe874 into red-hat-storage:main Oct 10, 2023
6 checks passed
@agarwal-mudit
Copy link
Member

/cherry-pick release-4.14

@openshift-cherrypick-robot

@agarwal-mudit: new pull request created: #2209

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Nikhil-Ladha
Copy link
Member Author

/cherry-pick release-4.12

@Nikhil-Ladha
Copy link
Member Author

/cherry-pick release-4.13

@openshift-cherrypick-robot

@Nikhil-Ladha: #2205 failed to apply on top of branch "release-4.12":

Applying: Fix typo in metrics code comment
Using index info to reconstruct a base tree...
M	metrics/internal/collectors/registry.go
Falling back to patching base and 3-way merge...
Auto-merging metrics/internal/collectors/registry.go
CONFLICT (content): Merge conflict in metrics/internal/collectors/registry.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix typo in metrics code comment
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@Nikhil-Ladha: new pull request created: #2236

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants