-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the OBC alert labels #2023
Fix the OBC alert labels #2023
Conversation
@aruniiird Is this required for 4.13? If yes do we have a bug? |
Yes @iamniting , BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2188032 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changed alerts are about OBC. Just changing the label to OB is not enough.
Either alert name, message, description everything needs to updated to OB or we need to add objectbucketclaim label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you just change the first part of expr to ocs_objectbucketclaim_info * on (namespace, objectbucket) group_left(objectbucketclaim)
it should work i.e. retain the objectbucketclaim label while joining the other half.
b8b015f
to
8f4f70b
Compare
Yes, you are right. The label, |
8f4f70b
to
69ab048
Compare
ObjectBucketClaim alerts had wrong label format, '{{$labels.objectbucketclaim}}' which has to be corrected/changed to '{{ $labels.objectbucketclaim }}'. Similar change to 'device_class' labels. Signed-off-by: Arun Kumar Mohan <[email protected]>
69ab048
to
2ada776
Compare
@umangachapagain , @iamniting , @SanjalKatiyar , now we have all the needed acks to the BZ#2188032 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aruniiird, iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.14 |
@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@iamniting: new pull request created: #2186 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.13 |
/cherry-pick release-4.12 |
/cherry-pick release-4.11 |
@agarwal-mudit: new pull request created: #2206 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@agarwal-mudit: new pull request created: #2207 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@agarwal-mudit: new pull request created: #2208 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ObjectBucketClaim alerts had wrong label format
Wrong format:
{{$labels.objectbucketclaim}}
Correct format:
{{ $labels.objectbucketclaim }}