Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the OBC alert labels #2023

Conversation

aruniiird
Copy link
Contributor

@aruniiird aruniiird commented Apr 20, 2023

ObjectBucketClaim alerts had wrong label format

Wrong format: {{$labels.objectbucketclaim}}
Correct format: {{ $labels.objectbucketclaim }}

@iamniting
Copy link
Member

@aruniiird Is this required for 4.13? If yes do we have a bug?

@aruniiird
Copy link
Contributor Author

@aruniiird Is this required for 4.13? If yes do we have a bug?

Yes @iamniting , BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2188032

Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changed alerts are about OBC. Just changing the label to OB is not enough.
Either alert name, message, description everything needs to updated to OB or we need to add objectbucketclaim label.

Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you just change the first part of expr to ocs_objectbucketclaim_info * on (namespace, objectbucket) group_left(objectbucketclaim) it should work i.e. retain the objectbucketclaim label while joining the other half.

@aruniiird aruniiird force-pushed the fix-objectbucketclaim-alert-labels branch 2 times, most recently from b8b015f to 8f4f70b Compare September 7, 2023 13:21
@aruniiird
Copy link
Contributor Author

All the changed alerts are about OBC. Just changing the label to OB is not enough. Either alert name, message, description everything needs to updated to OB or we need to add objectbucketclaim label.

Yes, you are right. The label, objectbucketclaim, is already added. Only the formatting was wrong (if you see other jsonnet files for label template). Corrected it

@aruniiird aruniiird force-pushed the fix-objectbucketclaim-alert-labels branch from 8f4f70b to 69ab048 Compare September 8, 2023 07:02
ObjectBucketClaim alerts had wrong label format, '{{$labels.objectbucketclaim}}'
which has to be corrected/changed to '{{ $labels.objectbucketclaim }}'.
Similar change to 'device_class' labels.

Signed-off-by: Arun Kumar Mohan <[email protected]>
@aruniiird aruniiird force-pushed the fix-objectbucketclaim-alert-labels branch from 69ab048 to 2ada776 Compare September 8, 2023 07:04
@aruniiird
Copy link
Contributor Author

@umangachapagain , @iamniting , @SanjalKatiyar , now we have all the needed acks to the BZ#2188032
Can we merge this today?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aruniiird, iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@iamniting
Copy link
Member

/cherry-pick release-4.14

@openshift-cherrypick-robot

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3fbc03a into red-hat-storage:main Sep 11, 2023
6 checks passed
@openshift-cherrypick-robot

@iamniting: new pull request created: #2186

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit
Copy link
Member

/cherry-pick release-4.13

@agarwal-mudit
Copy link
Member

/cherry-pick release-4.12

@agarwal-mudit
Copy link
Member

/cherry-pick release-4.11

@openshift-cherrypick-robot

@agarwal-mudit: new pull request created: #2206

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@agarwal-mudit: new pull request created: #2207

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@agarwal-mudit: new pull request created: #2208

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants