provider: don't re-use 'err' variable in job creation

Signed-off-by: Jose A. Rivera <[email protected]>
red-hat-storage · Mar 8, 2024 · e6e778b · e6e778b
1 parent 49681da
commit e6e778b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/controllers/storagecluster/provider_server.go b/controllers/storagecluster/provider_server.go
@@ -496,9 +496,12 @@ func (o *ocsProviderServer) createJob(r *StorageClusterReconciler, instance *ocs
 
 	if errors.IsNotFound(err) {
 		onboardingSecretGeneratorJob := getOnboardingJobObject(instance)
-		err = r.Client.Create(context.Background(), onboardingSecretGeneratorJob)
-	}
-	if err != nil {
+		jobErr := r.Client.Create(context.Background(), onboardingSecretGeneratorJob)
+		if jobErr != nil && !errors.IsAlreadyExists(jobErr) {
+			r.Log.Error(jobErr, "failed to create onboarding job")
+			return reconcile.Result{}, jobErr
+		}
+	} else if err != nil {
 		r.Log.Error(err, "failed to create/ensure secret")
 		return reconcile.Result{}, err
 	}