Refactor & simplify functest make target & hack script

Signed-off-by: Malay Kumar Parida <[email protected]>

Makefile

@@ -98,11 +98,8 @@ cluster-clean:
 	@echo "Removing ocs install from cluster"
 	hack/cluster-clean.sh
 
-build-functest:
-	@echo "Building functional tests"
-	hack/build-functest.sh
 
-functest: build-functest
+functest:
 	@echo "Running ocs developer functional test suite"
 	hack/functest.sh $(ARGS)
 

hack/functest.sh

@@ -1,7 +1,22 @@
 #!/usr/bin/env bash
 
+set -e
+
 source hack/common.sh
 
+mkdir -p "${LOCALBIN}"
+
+if ! [ -x "$GINKGO" ]; then
+	echo "Installing GINKGO binary at $GINKGO"
+	GOBIN=${LOCALBIN} go install github.com/onsi/ginkgo/v2/ginkgo
+else
+	echo "GINKO binary found at $GINKGO"
+fi
+
+"${GINKGO}" build --ldflags "${LDFLAGS}" "functests/${GINKGO_TEST_SUITE}/"
+
+mv "functests/${GINKGO_TEST_SUITE}/${GINKGO_TEST_SUITE}.test" "${LOCALBIN}/${GINKGO_TEST_SUITE}_tests"
+
 "${LOCALBIN}/${GINKGO_TEST_SUITE}_tests" -ginkgo.v \
     	--ocs-catalog-image="${FILE_BASED_CATALOG_FULL_IMAGE_NAME}" \
 	--ocs-subscription-channel="${OCS_SUBSCRIPTION_CHANNEL}" \