Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csi: use static name for cephfs/rbd #61

Merged

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Jan 22, 2024

use the static provisioner name for both cephfs and rbd csi driver irrespective of the namespace where they are deployed.

@Madhu-1 Madhu-1 requested a review from nb-ohad January 22, 2024 15:09
use the static provisioner name for
both cephfs and rbd csi driver
irrespective of the namespace where they
are deployed.

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1 Madhu-1 force-pushed the csidriver-nameprefix branch from 08d9128 to 8d70602 Compare January 22, 2024 15:12
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 22, 2024
@Madhu-1
Copy link
Member Author

Madhu-1 commented Jan 23, 2024

@nb-ohad PTAL

@nb-ohad
Copy link
Contributor

nb-ohad commented Jan 24, 2024

/lgtm

@Madhu-1
Copy link
Member Author

Madhu-1 commented Jan 24, 2024

@nb-ohad this also needs /approve label as well. can you please help with that?

@nb-ohad
Copy link
Contributor

nb-ohad commented Jan 24, 2024

/approve

Copy link

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Madhu-1, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7cfec77 into red-hat-storage:main Jan 24, 2024
14 checks passed
@leelavg
Copy link
Contributor

leelavg commented Jan 24, 2024

/cherry-pick fusion-hci-4.14

@leelavg
Copy link
Contributor

leelavg commented Jan 24, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@leelavg: new pull request created: #62

In response to this:

/cherry-pick fusion-hci-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@leelavg: new pull request created: #63

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants