-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install CSI driver #3
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,6 +70,7 @@ | |
"action", | ||
"api", | ||
"bundle", | ||
"csi", | ||
"ci", | ||
"console", | ||
"controllers", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,7 +47,7 @@ lint: ## Run golangci-lint against code. | |
docker run --rm -v $(PROJECT_DIR):/app:Z -w /app $(GO_LINT_IMG) golangci-lint run ./... | ||
|
||
godeps-update: ## Run go mod tidy & vendor | ||
go mod tidy -compat=1.17 && go mod vendor | ||
go mod tidy && go mod vendor | ||
|
||
test-setup: godeps-update generate fmt vet ## Run setup targets for tests | ||
|
||
|
@@ -64,6 +64,7 @@ e2e-test: ginkgo ## TODO: Run end to end functional tests. | |
##@ Build | ||
|
||
build: container-build ## Build manager binary | ||
go build -o ./bin/manager main.go | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are you doing a local build after the container build? Best I remember, the use of a local go build should not be part of the default build procedure, we should always be using the container build unless the developer has a specific reason they need to do the local build during development. Beyond this, there's already a |
||
|
||
go-build: ## Run go build against code. | ||
@GOBIN=${GOBIN} ./hack/go-build.sh | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,9 +14,9 @@ See the License for the specific language governing permissions and | |
limitations under the License. | ||
*/ | ||
|
||
// Package v1alpha1 contains API Schema definitions for the odf v1alpha1 API group | ||
//+kubebuilder:object:generate=true | ||
//+groupName=odf.openshift.io | ||
// Package v1alpha1 contains API Schema definitions for the ocs v1alpha1 API group | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any specific reason for changing the group name? This is technically part of ODF. |
||
// +kubebuilder:object:generate=true | ||
// +groupName=ocs.openshift.io | ||
package v1alpha1 | ||
|
||
import ( | ||
|
@@ -26,7 +26,7 @@ import ( | |
|
||
var ( | ||
// GroupVersion is group version used to register these objects | ||
GroupVersion = schema.GroupVersion{Group: "odf.openshift.io", Version: "v1alpha1"} | ||
GroupVersion = schema.GroupVersion{Group: "ocs.openshift.io", Version: "v1alpha1"} | ||
|
||
// SchemeBuilder is used to add go types to the GroupVersionKind scheme | ||
SchemeBuilder = &scheme.Builder{GroupVersion: GroupVersion} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix indentation