Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DFBUGS-925]:[release-4.18] api: make inMaintenanceMode optional #283

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #281

/assign openshift-ci-robot

olm stops operator updates when a new field is introduced with
a required qualifer, hence we need to make it optional

Signed-off-by: Rewant Soni <[email protected]>
Copy link

openshift-ci bot commented Nov 26, 2024

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: openshift-ci-robot.

Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #281

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rewantsoni
Copy link
Member

rewantsoni commented Nov 26, 2024

/retitle: DFBUGS-925: [release-4.18] api: make inMaintenanceMode optional

@openshift-ci openshift-ci bot changed the title [release-4.18] api: make inMaintenanceMode optional : DFBUGS-925: [release-4.18] api: make inMaintenanceMode optional Nov 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925), which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #281

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rewantsoni
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024

@rewantsoni: This pull request references [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rewantsoni
Copy link
Member

/retitle DFBUGS-925: [release-4.18] api: make inMaintenanceMode optional

@openshift-ci openshift-ci bot changed the title : DFBUGS-925: [release-4.18] api: make inMaintenanceMode optional [DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925): [release-4.18] api: make inMaintenanceMode optional Nov 26, 2024
@leelavg leelavg changed the title [DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925): [release-4.18] api: make inMaintenanceMode optional [DFBUGS-925]:[release-4.18] api: make inMaintenanceMode optional Nov 26, 2024
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg leelavg added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Nov 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d2755c2 into red-hat-storage:release-4.18 Nov 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants