Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBAC permissions alignment #141

Closed
wants to merge 1 commit into from

Conversation

bernerhat
Copy link
Contributor

addition and removale of rbac permissions based on operations handled by each controller, also handles issue #82

Copy link

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bernerhat
Once this PR has been reviewed and has the lgtm label, please assign nb-ohad for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bernerhat
Copy link
Contributor Author

/hold

@bernerhat bernerhat changed the title controllers: rbac permissions alignment RBAC permissions alignment Apr 15, 2024
@bernerhat bernerhat force-pushed the rbac-modification branch from 5398a9c to ea2477f Compare May 20, 2024 08:04
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pls update the rbac in the bundle as well?

addition and removale of rbac permissions based on operations handled by each controller

Signed-off-by: Amit Berner <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@leelavg
Copy link
Contributor

leelavg commented Nov 20, 2024

closing as these are already done as part of #260

@leelavg leelavg closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants